http://trac.webkit.org/changeset/63463 broke run-javascriptore-tests, run-sunspider, ... scripts with QtWebKit on Windows, because $productDir/$jscName isn't exist, but $productDir/$jscName.exe. exe suffix is neccessary when you test file existance, but unneccessary when you execute the binarty. http://trac.webkit.org/changeset/63463: - return "$productDir/$jscName"; + return "$productDir/$jscName" if -e "$productDir/$jscName"; + return "$productDir/JavaScriptCore.framework/Resources/$jscName";
Created attachment 67394 [details] proposed fix
Comment on attachment 67394 [details] proposed fix > + $jscName .= ".exe" if (isQt() && isWindows()); This doesn't strike me as a Qt-specific issue.
(In reply to comment #2) > (From update of attachment 67394 [details]) > > + $jscName .= ".exe" if (isQt() && isWindows()); > > This doesn't strike me as a Qt-specific issue. It shouldn't be Qt specific issue, but I'm not sure. On Apple Windows port run-javascriptcore-tests works correctly, it seems the file existance check works without "exe" suffix inside cygwin. I will check it ASAP.
Comment on attachment 67394 [details] proposed fix new patch is coming soon
Created attachment 67413 [details] proposed fix proposed fix: + $jscName .= ".exe" if (isWindows() || isCygwin()); The root of the problem was that ' if -e "executableBinary" ' is false with ActiveState perl on Windows in cmd.exe shell, but true in CygWin shell if executableBinary.exe exist, but executableBinary doesn't. It is a misleading perl feature what we should avoid, so I propose to add ".exe" suffix for Windows and CygWin platform too.
Comment on attachment 67413 [details] proposed fix Nice detective work :) r=me
Comment on attachment 67413 [details] proposed fix Clearing flags on attachment: 67413 Committed r67391: <http://trac.webkit.org/changeset/67391>
All reviewed patches have been landed. Closing bug.