RESOLVED FIXED Bug 45643
[Qt] Don't add empty strings to list of supported image MIME types 
https://bugs.webkit.org/show_bug.cgi?id=45643
Summary [Qt] Don't add empty strings to list of supported image MIME types
Andreas Kling
Reported 2010-09-13 02:10:09 PDT
After <http://trac.webkit.org/changeset/67355> getMIMETypeForExtension() returns an empty string instead of "application/octet-stream" for unsupported extensions. We shouldn't add this to the list of supported types. We can also remove the logic in initializeSupportedImageMIMETypes() and initializeSupportedImageMIMETypesForEncoding() that cleans out "application/octet-stream" from the list of supported types.
Attachments
Proposed patch (2.51 KB, patch)
2010-09-13 02:11 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Proposed patch v2 (r=kenneth) (4.99 KB, patch)
2010-09-13 03:11 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Proposed patch v3 (r=kenneth) (2.63 KB, patch)
2010-09-13 03:13 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2010-09-13 02:11:50 PDT
Created attachment 67380 [details] Proposed patch
Kenneth Rohde Christiansen
Comment 2 2010-09-13 02:34:16 PDT
Comment on attachment 67380 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=67380&action=prettypatch Any tests for this?
Andreas Kling
Comment 3 2010-09-13 03:11:35 PDT
Created attachment 67389 [details] Proposed patch v2 (r=kenneth) Don't know how to test this since I'd need to call WebCore internals. Added comment to ChangeLog about this fixing a crash in initializeMIMETypeRegistry().
Andreas Kling
Comment 4 2010-09-13 03:13:29 PDT
Created attachment 67390 [details] Proposed patch v3 (r=kenneth) Oops, remove junk from patch.
Andreas Kling
Comment 5 2010-09-13 03:15:42 PDT
Comment on attachment 67390 [details] Proposed patch v3 (r=kenneth) Clearing flags on attachment: 67390 Committed r67375: <http://trac.webkit.org/changeset/67375>
Andreas Kling
Comment 6 2010-09-13 03:15:53 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 7 2010-09-13 04:16:49 PDT
http://trac.webkit.org/changeset/67375 might have broken Qt Linux Release The following changes are on the blame list: http://trac.webkit.org/changeset/67376 http://trac.webkit.org/changeset/67375
Ademar Reis
Comment 8 2011-01-26 13:17:02 PST
Revision r67375 cherry-picked into qtwebkit-2.1.x with commit 495f6f1 <http://gitorious.org/webkit/qtwebkit/commit/495f6f1>
Note You need to log in before you can comment on or make changes to this bug.