Bug 45618 - [Qt] Remove Path::closeSubpath() workaround for broken miter joins
Summary: [Qt] Remove Path::closeSubpath() workaround for broken miter joins
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: QtWebKit Unassigned
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2010-09-12 11:22 PDT by Andreas Kling
Modified: 2010-09-12 11:36 PDT (History)
0 users

See Also:


Attachments
Proposed patch (4.24 KB, patch)
2010-09-12 11:25 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2010-09-12 11:22:14 PDT
In <http://trac.webkit.org/changeset/66948> Path::closeCanvasSubpath() was added to fix around a problem that wasn't fully understood at the time.

It turns out that the whole thing was a bug in Qt's SVG-compliant path stroker. It has been fixed for Qt 4.7.1 and we should remove the workaround kludge from WebKit.
Comment 1 Andreas Kling 2010-09-12 11:25:56 PDT
Created attachment 67339 [details]
Proposed patch
Comment 2 Andreas Kling 2010-09-12 11:36:05 PDT
Comment on attachment 67339 [details]
Proposed patch

Clearing flags on attachment: 67339

Committed r67339: <http://trac.webkit.org/changeset/67339>
Comment 3 Andreas Kling 2010-09-12 11:36:15 PDT
All reviewed patches have been landed.  Closing bug.