applyInlineStyleToNodeRange does not extend a run properly

[Ryosuke Niwa]

In the current implementation of applyInlineStyleToNodeRange, we do not start a run from a node that contains child nodes.
We also fail to remove redundant styled elements in a run.

[Ryosuke Niwa]

Created attachment 67338 [details]
fixes the bug

[Tony Chang]

Comment on attachment 67338 [details]
fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=67338&action=prettypatch

> WebCore/editing/ApplyStyleCommand.cpp:1170
> -        if (mode == RemoveAttributesAndElements)
> +        if (mode == RemoveIfNeeded)
>              removeNodePreservingChildren(element);
Should mode == RemoveAlways also cause us to removeNodePreservingChildren?

[Ryosuke Niwa]

(In reply to comment #2)
> (From update of attachment 67338 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=67338&action=prettypatch
> 
> > WebCore/editing/ApplyStyleCommand.cpp:1170
> > -        if (mode == RemoveAttributesAndElements)
> > +        if (mode == RemoveIfNeeded)
> >              removeNodePreservingChildren(element);
> Should mode == RemoveAlways also cause us to removeNodePreservingChildren?

That's a very valid point.  Let me fix that.

[Ryosuke Niwa]

Created attachment 67471 [details]
fixed per Tony's comment

[Ryosuke Niwa]

Committed r67449: <http://trac.webkit.org/changeset/67449>

[WebKit Review Bot]

http://trac.webkit.org/changeset/67449 might have broken Qt Linux Release minimal
The following changes are on the blame list:
http://trac.webkit.org/changeset/67449
http://trac.webkit.org/changeset/67450
http://trac.webkit.org/changeset/67451

[Ryosuke Niwa]

http://trac.webkit.org/changeset/67459 rolled out this patch due the failure of /fast/events/event-input-contentEditable.html

Will rebaseline this patch and commit again.

[Eric Seidel (no email)]

I can't tell who was to blame, I thought bug 45071 was what caused that test to regress?

[Ryosuke Niwa]

Committed r67490: <http://trac.webkit.org/changeset/67490>