WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
45605
Implement WebKit2 callback equivalent to - [WebUIDelegate webView:setStatusText:]
https://bugs.webkit.org/show_bug.cgi?id=45605
Summary
Implement WebKit2 callback equivalent to - [WebUIDelegate webView:setStatusTe...
Sam Weinig
Reported
2010-09-11 18:44:01 PDT
Implement WebKit2 callback equivalent to - [WebUIDelegate webView:setStatusText:]
Attachments
Patch
(11.52 KB, patch)
2010-09-11 18:46 PDT
,
Sam Weinig
mitz: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Sam Weinig
Comment 1
2010-09-11 18:44:10 PDT
<
rdar://problem/8359252
>
Sam Weinig
Comment 2
2010-09-11 18:46:10 PDT
Created
attachment 67322
[details]
Patch
WebKit Review Bot
Comment 3
2010-09-11 18:47:11 PDT
Attachment 67322
[details]
did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/UIProcess/API/C/WKPage.h:155: Extra space between WKPageSetStatusTextCallback and setStatusText [whitespace/declaration] [3] Total errors found: 1 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 4
2010-09-11 18:50:48 PDT
Landed in
r67312
.
Early Warning System Bot
Comment 5
2010-09-11 19:03:05 PDT
Attachment 67322
[details]
did not build on qt: Build output:
http://queues.webkit.org/results/3949393
WebKit Review Bot
Comment 6
2010-09-11 19:20:48 PDT
http://trac.webkit.org/changeset/67312
might have broken GTK Linux 32-bit Release
Daniel Bates
Comment 7
2010-09-11 23:44:35 PDT
(In reply to
comment #4
)
> Landed in
r67312
.
This change broke the Qt Linux Release bot. The stdio from the bot is at <
http://build.webkit.org/builders/Qt%20Linux%20Release/builds/19764/steps/compile-webkit/logs/stdio
>. It looks like a comma ',' is missing in the WKPageUIClient initialization list. Committed fix in changeset 67318 <
http://trac.webkit.org/changeset/67318
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug