WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
45602
Remove unneeded Empty Queue messages
https://bugs.webkit.org/show_bug.cgi?id=45602
Summary
Remove unneeded Empty Queue messages
Eric Seidel (no email)
Reported
2010-09-11 15:31:39 PDT
Remove unneeded Empty Queue messages
Attachments
Patch
(2.03 KB, patch)
2010-09-11 15:35 PDT
,
Eric Seidel (no email)
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1
2010-09-11 15:35:53 PDT
Created
attachment 67316
[details]
Patch
Eric Seidel (no email)
Comment 2
2010-09-11 15:37:14 PDT
We might have to make
http://queues.webkit.org/queue-status/commit-queue
show the "last_status_date" like / does.
Mihai Parparita
Comment 3
2010-09-11 15:51:50 PDT
Comment on
attachment 67316
[details]
Patch BTW, /gc has been timing out based on the App Engine logs.
WebKit Commit Bot
Comment 4
2010-09-11 15:53:27 PDT
Comment on
attachment 67316
[details]
Patch Rejecting patch 67316 from review queue.
mihaip@chromium.org
does not have reviewer permissions according to
http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py
. - If you do not have reviewer rights please read
http://webkit.org/coding/contributing.html
for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights.
WebKit Commit Bot
Comment 5
2010-09-11 15:55:33 PDT
Comment on
attachment 67316
[details]
Patch Rejecting patch 67316 from commit-queue.
mihaip@chromium.org
does not have committer permissions according to
http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py
. - If you do not have committer rights please read
http://webkit.org/coding/contributing.html
for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
Eric Seidel (no email)
Comment 6
2010-09-11 15:59:18 PDT
Comment on
attachment 67316
[details]
Patch :)
Adam Barth
Comment 7
2010-09-11 16:05:38 PDT
Comment on
attachment 67316
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=67316&action=prettypatch
OMG
WebKit Commit Bot
Comment 8
2010-09-11 16:25:41 PDT
Comment on
attachment 67316
[details]
Patch Clearing flags on attachment: 67316 Committed
r67310
: <
http://trac.webkit.org/changeset/67310
>
WebKit Commit Bot
Comment 9
2010-09-11 16:25:49 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug