Bug 45591 – Add WTF::equal for StringImpl and char* with explicit length

• Status: RESOLVED
• Resolution: CONFIGURATION CHANGED
• Component: Web Template Framework

[Patrick R. Gansterer]

see patch

[Patrick R. Gansterer]

Created attachment 67300 [details]
Patch

I'll use this function for performance improvements of XMLParser (bug 43085).

[Patrick R. Gansterer]

Comment on attachment 67300 [details]
Patch

Maybe I'll move the function into AtomicString for inlineing.

[Ahmad Saleem]

Attached patch was modifying "equalIgnoringCase" - which was removed in below commit:

https://github.com/WebKit/WebKit/commit/507aa34586fdcf0b9a5ea433c2402f295a717da8

Further - "createStrippingNullCharactersSlowCase" - it had only one commit below:

https://github.com/WebKit/WebKit/commit/663efc5d78ea61ca1b418dbd67f3cd91676910a2

but even it was removed here:

https://github.com/WebKit/WebKit/commit/539e5655d6da61859c0f9448691eea1892cae8bc

So I don't think this patch can be applied to Github main / trunk / master branch since it has been changed drastically.

Can someone comment whether it is something needed out of this or this can be marked as "RESOLVED WONTFIX"? Thanks!

[Alexey Proskuryakov]

We have such functions now.

WTF_EXPORT_PRIVATE bool equal(const StringImpl*, const LChar*, unsigned);
WTF_EXPORT_PRIVATE bool equal(const StringImpl*, const UChar*, unsigned);
ALWAYS_INLINE bool equal(const StringImpl* a, ASCIILiteral b) { return equal(a, b.characters8(), b.length()); }
inline bool equal(const StringImpl* a, const char* b, unsigned length) { return equal(a, reinterpret_cast<const LChar*>(b), length); }