Bug 45587 - Line clamp cleanup
Summary: Line clamp cleanup
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-10 23:01 PDT by Adele Peterson
Modified: 2010-09-11 06:21 PDT (History)
1 user (show)

See Also:

Attachments
patch (12.41 KB, patch)
2010-09-10 23:04 PDT, Adele Peterson 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adele Peterson 2010-09-10 23:01:46 PDT 
Move line clamp to its own function
Comment 1 Adele Peterson 2010-09-10 23:04:32 PDT 
Created attachment 67293 [details]
patch
Comment 2 WebKit Review Bot 2010-09-10 23:06:04 PDT 
Attachment 67293 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/rendering/RenderFlexibleBox.cpp:906:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Adele Peterson 2010-09-11 06:21:21 PDT 
Committed revision 67296.