Bug 45578 - editing/inserting/insert-3659587-fix.html and editing/style/style-3690704-fix.html should use runDumpAsTextEditingTest
Summary: editing/inserting/insert-3659587-fix.html and editing/style/style-3690704-fix...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Blocker
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 45568
  Show dependency treegraph
 
Reported: 2010-09-10 17:00 PDT by Ryosuke Niwa
Modified: 2010-09-10 22:08 PDT (History)
5 users (show)

See Also:


Attachments
Patch (52.66 KB, patch)
2010-09-10 17:10 PDT, Ryosuke Niwa
tony: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2010-09-10 17:00:44 PDT
editing/inserting/insert-3659587-fix.html and editing/style/style-3690704-fix.html
should use runDumpAsTextEditingTest() instead of runEditingTest().
Comment 1 Ryosuke Niwa 2010-09-10 17:10:33 PDT
Created attachment 67270 [details]
Patch
Comment 2 Tony Chang 2010-09-10 17:20:06 PDT
Comment on attachment 67270 [details]
Patch

It is very hard for me to tell what editing/inserting/insert-3659587-fix.html is testing, but it seems like having the DOM with <br>s is sufficient.
Comment 3 Ryosuke Niwa 2010-09-10 17:31:14 PDT
(In reply to comment #2)
> (From update of attachment 67270 [details])
> It is very hard for me to tell what editing/inserting/insert-3659587-fix.html is testing, but it seems like having the DOM with <br>s is sufficient.

Indeed.  The test was added in http://trac.webkit.org/changeset/6826/trunk/LayoutTests/editing/inserting/insert-3659587-fix.html with a very cryptic changelog.
Comment 4 Darin Adler 2010-09-10 18:21:09 PDT
Bug 3659587 was:

STEPS TO REPRODUCE:
1. Open a new document in Blot.  Type "hello"
2. select all with cmd-a.  make bold with shift-cmd-b.
3. press right arrow to move caret to end of line.  type " hello" (text is bold)
4. press return key.  type "world"

RESULTS:
On the second line, "world" is in regular text, not bold text.  "world" should also be bold.
Comment 5 Ryosuke Niwa 2010-09-10 20:59:22 PDT
(In reply to comment #4)
> Bug 3659587 was:
> 
> STEPS TO REPRODUCE:
> 1. Open a new document in Blot.  Type "hello"
> 2. select all with cmd-a.  make bold with shift-cmd-b.
> 3. press right arrow to move caret to end of line.  type " hello" (text is bold)
> 4. press return key.  type "world"
> 
> RESULTS:
> On the second line, "world" is in regular text, not bold text.  "world" should also be bold.

Thanks for the information, Darin!  I'll add the following description before I commit:
Test that inserting a line break will preserve bolding. All of the text below should be bold.
Comment 6 Ryosuke Niwa 2010-09-10 22:08:53 PDT
Committed r67277: <http://trac.webkit.org/changeset/67277>