RESOLVED FIXED45552
[chromium] Make compositor obey finish flag 
https://bugs.webkit.org/show_bug.cgi?id=45552
Summary [chromium] Make compositor obey finish flag
Nat Duca
Reported 2010-09-10 11:23:02 PDT
The compositor should obey the finish flag on doComposite. Paired with a Chromium-side change, this will fix our resizing problems.
Attachments
First attempt. (3.46 KB, patch)
2010-09-10 11:41 PDT, Nat Duca 		no flags
DetailsFormatted DiffDiff
Fixed tabs (3.46 KB, patch)
2010-09-14 12:07 PDT, Nat Duca 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nat Duca
Comment 1 2010-09-10 11:41:18 PDT
Created attachment 67211 [details] First attempt.
Nat Duca
Comment 2 2010-09-13 17:08:25 PDT
Comment on attachment 67211 [details] First attempt. I think we can land this now?
Darin Fisher (:fishd, Google)
Comment 3 2010-09-13 21:26:28 PDT
Comment on attachment 67211 [details] First attempt. View in context: https://bugs.webkit.org/attachment.cgi?id=67211&action=prettypatch > WebKit/chromium/src/WebViewImpl.cpp:989 > + m_layerRenderer->finish(); nit: indentation needs to be 4 spaces otherwise, R=me
Nat Duca
Comment 4 2010-09-14 12:07:01 PDT
Created attachment 67584 [details] Fixed tabs
Eric Seidel (no email)
Comment 5 2010-09-15 15:47:14 PDT
Comment on attachment 67211 [details] First attempt. Cleared Darin Fisher's review+ from obsolete attachment 67211 [details] so that this bug does not appear in http://webkit.org/pending-commit.
WebKit Commit Bot
Comment 6 2010-09-16 05:51:16 PDT
Comment on attachment 67584 [details] Fixed tabs Clearing flags on attachment: 67584 Committed r67610: <http://trac.webkit.org/changeset/67610>
WebKit Commit Bot
Comment 7 2010-09-16 05:51:21 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.