Bug 45552 - [chromium] Make compositor obey finish flag
Summary: [chromium] Make compositor obey finish flag
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-10 11:23 PDT by Nat Duca
Modified: 2010-09-16 05:51 PDT (History)
3 users (show)

See Also:


Attachments
First attempt. (3.46 KB, patch)
2010-09-10 11:41 PDT, Nat Duca
no flags Details | Formatted Diff | Diff
Fixed tabs (3.46 KB, patch)
2010-09-14 12:07 PDT, Nat Duca
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nat Duca 2010-09-10 11:23:02 PDT
The compositor should obey the finish flag on doComposite. Paired with a Chromium-side change, this will fix our resizing problems.
Comment 1 Nat Duca 2010-09-10 11:41:18 PDT
Created attachment 67211 [details]
First attempt.
Comment 2 Nat Duca 2010-09-13 17:08:25 PDT
Comment on attachment 67211 [details]
First attempt.

I think we can land this now?
Comment 3 Darin Fisher (:fishd, Google) 2010-09-13 21:26:28 PDT
Comment on attachment 67211 [details]
First attempt.

View in context: https://bugs.webkit.org/attachment.cgi?id=67211&action=prettypatch

> WebKit/chromium/src/WebViewImpl.cpp:989
> +      m_layerRenderer->finish();
nit: indentation needs to be 4 spaces

otherwise, R=me
Comment 4 Nat Duca 2010-09-14 12:07:01 PDT
Created attachment 67584 [details]
Fixed tabs
Comment 5 Eric Seidel (no email) 2010-09-15 15:47:14 PDT
Comment on attachment 67211 [details]
First attempt.

Cleared Darin Fisher's review+ from obsolete attachment 67211 [details] so that this bug does not appear in http://webkit.org/pending-commit.
Comment 6 WebKit Commit Bot 2010-09-16 05:51:16 PDT
Comment on attachment 67584 [details]
Fixed tabs

Clearing flags on attachment: 67584

Committed r67610: <http://trac.webkit.org/changeset/67610>
Comment 7 WebKit Commit Bot 2010-09-16 05:51:21 PDT
All reviewed patches have been landed.  Closing bug.