Bug 45548 - AX: accessibilityIsIgnored is returning nil when return value expects a BOOL
Summary: AX: accessibilityIsIgnored is returning nil when return value expects a BOOL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: chris fleizach
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-10 09:32 PDT by chris fleizach
Modified: 2010-09-13 15:49 PDT (History)
4 users (show)

See Also:


Attachments
patch (1.29 KB, patch)
2010-09-10 09:46 PDT, chris fleizach
ddkilzer: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description chris fleizach 2010-09-10 09:32:40 PDT
this will actually result in an element NOT being ignored when it should, since returning NO (or nil) will make it appear in the hierarchy in these error cases
Comment 1 chris fleizach 2010-09-10 09:46:03 PDT
Created attachment 67197 [details]
patch
Comment 2 David Kilzer (:ddkilzer) 2010-09-11 04:35:14 PDT
Comment on attachment 67197 [details]
patch

r=me

It would be great if you could write a test for this as well!  :)
Comment 3 chris fleizach 2010-09-13 14:02:28 PDT
will add layout test as well (figured out how to do so)
Comment 4 chris fleizach 2010-09-13 14:07:07 PDT
http://trac.webkit.org/changeset/67408