Bug 45547 - Fix a windows build of plugins
Summary: Fix a windows build of plugins
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-10 09:20 PDT by Fridrich Strba
Modified: 2010-10-13 21:32 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.01 KB, patch)
2010-09-10 09:21 PDT, Fridrich Strba 		no flags Details | Formatted Diff | Diff
Patch (1002 bytes, patch)
2010-09-10 09:52 PDT, Fridrich Strba 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fridrich Strba 2010-09-10 09:20:08 PDT 
Add a WebCore/plugins/win directory among the directories where to look for include files, since it contains some include files needed for the Windows build.
Comment 1 Fridrich Strba 2010-09-10 09:21:34 PDT 
Created attachment 67193 [details]
Patch
Comment 2 Andreas Kling 2010-09-10 09:28:05 PDT 
Comment on attachment 67193 [details]
Patch

> +	-I$(srcdir)/WebCore/plugins/win \

Wouldn't this fit better into the "TARGET_WIN32" section?
Comment 3 Fridrich Strba 2010-09-10 09:34:47 PDT 
(In reply to comment #2)
> (From update of attachment 67193 [details])
> > +	-I$(srcdir)/WebCore/plugins/win \
> 
> Wouldn't this fit better into the "TARGET_WIN32" section?

Just a matter of taste because the files there will be included only if the following condition is fulfilled:

#elif defined(GDK_WINDOWING_WIN32)
#include "PluginMessageThrottlerWin.h"
#include <gdk/gdkwin32.h>
#endif

So, if you can accept it as it is, it is ok, if not I will redo the patch.
Comment 4 Fridrich Strba 2010-09-10 09:52:08 PDT 
Created attachment 67198 [details]
Patch
Comment 5 WebKit Commit Bot 2010-10-13 19:03:12 PDT 
Comment on attachment 67198 [details]
Patch

Clearing flags on attachment: 67198

Committed r69726: <http://trac.webkit.org/changeset/69726>
Comment 6 WebKit Commit Bot 2010-10-13 19:03:17 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 WebKit Review Bot 2010-10-13 21:32:38 PDT 
http://trac.webkit.org/changeset/69726 might have broken GTK Linux 64-bit Debug
The following tests are not passing:
canvas/philip/tests/2d.gradient.radial.negative.html
editing/selection/context-menu-on-text.html