Bug 45543 – Make webkit-gtk windows build not to depend on pthreads

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Fridrich Strba]

The windows implementation of pthreads is undermaintained, and it is perfectly possible to build webkit-gtk without using pthreads

[Fridrich Strba]

Created attachment 67188 [details]
Patch 1

[Xan Lopez]

Comment on attachment 67188 [details]
Patch 1

The reason why we started using pthreads was, in fact, GTK/win32, so if pthreads is actually worse there I think we should just drop the usage completely. See http://trac.webkit.org/changeset/37732

[Fridrich Strba]

Created attachment 67461 [details]
Avoid gratuitous dependency on pthreads-win32

[WebKit Review Bot]

Attachment 67461 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
JavaScriptCore/wtf/TCSpinLock.h:140:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
JavaScriptCore/wtf/TCSpinLock.h:142:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Fridrich Strba]

(In reply to comment #4)
> Attachment 67461 [details] did not pass style-queue:
> Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
> JavaScriptCore/wtf/TCSpinLock.h:140:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
> JavaScriptCore/wtf/TCSpinLock.h:142:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
> Total errors found: 2 in 2 files

The problem is that in this particular file, all indentation is done by two spaces. I can fix this easily by making those two lines indented by 4 spaces but it will make the readability a mess. The other solution would be to reformat the file, but there again, it would mean to have a huge whitespace modification :(

[WebKit Commit Bot]

Comment on attachment 67461 [details]
Avoid gratuitous dependency on pthreads-win32

Clearing flags on attachment: 67461

Committed r69728: <http://trac.webkit.org/changeset/69728>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

http://trac.webkit.org/changeset/69728 might have broken GTK Linux 64-bit Debug
The following tests are not passing:
canvas/philip/tests/2d.gradient.radial.negative.html
editing/selection/context-menu-on-text.html