Bug 45543 - Make webkit-gtk windows build not to depend on pthreads
Summary: Make webkit-gtk windows build not to depend on pthreads
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-10 08:25 PDT by Fridrich Strba
Modified: 2010-10-13 21:32 PDT (History)
7 users (show)

See Also:


Attachments
Patch 1 (2.87 KB, patch)
2010-09-10 08:31 PDT, Fridrich Strba
no flags Details | Formatted Diff | Diff
Avoid gratuitous dependency on pthreads-win32 (1.70 KB, patch)
2010-09-13 13:13 PDT, Fridrich Strba
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fridrich Strba 2010-09-10 08:25:41 PDT
The windows implementation of pthreads is undermaintained, and it is perfectly possible to build webkit-gtk without using pthreads
Comment 1 Fridrich Strba 2010-09-10 08:31:14 PDT
Created attachment 67188 [details]
Patch 1
Comment 2 Xan Lopez 2010-09-13 00:28:59 PDT
Comment on attachment 67188 [details]
Patch 1

The reason why we started using pthreads was, in fact, GTK/win32, so if pthreads is actually worse there I think we should just drop the usage completely. See http://trac.webkit.org/changeset/37732
Comment 3 Fridrich Strba 2010-09-13 13:13:50 PDT
Created attachment 67461 [details]
Avoid gratuitous dependency on pthreads-win32
Comment 4 WebKit Review Bot 2010-09-13 13:17:29 PDT
Attachment 67461 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
JavaScriptCore/wtf/TCSpinLock.h:140:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
JavaScriptCore/wtf/TCSpinLock.h:142:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Fridrich Strba 2010-09-13 14:21:59 PDT
(In reply to comment #4)
> Attachment 67461 [details] did not pass style-queue:
> Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
> JavaScriptCore/wtf/TCSpinLock.h:140:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
> JavaScriptCore/wtf/TCSpinLock.h:142:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
> Total errors found: 2 in 2 files

The problem is that in this particular file, all indentation is done by two spaces. I can fix this easily by making those two lines indented by 4 spaces but it will make the readability a mess. The other solution would be to reformat the file, but there again, it would mean to have a huge whitespace modification :(
Comment 6 WebKit Commit Bot 2010-10-13 19:16:30 PDT
Comment on attachment 67461 [details]
Avoid gratuitous dependency on pthreads-win32

Clearing flags on attachment: 67461

Committed r69728: <http://trac.webkit.org/changeset/69728>
Comment 7 WebKit Commit Bot 2010-10-13 19:16:35 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 WebKit Review Bot 2010-10-13 21:32:57 PDT
http://trac.webkit.org/changeset/69728 might have broken GTK Linux 64-bit Debug
The following tests are not passing:
canvas/philip/tests/2d.gradient.radial.negative.html
editing/selection/context-menu-on-text.html