Bug 45542 - Rebaseline DeviceOrientation related layout tests for Chromium.
Summary: Rebaseline DeviceOrientation related layout tests for Chromium.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-10 08:23 PDT by Hans Wennborg
Modified: 2010-09-14 08:31 PDT (History)
3 users (show)

See Also:


Attachments
Patch (59.72 KB, patch)
2010-09-10 08:50 PDT, Hans Wennborg
no flags Details | Formatted Diff | Diff
Patch (96.79 KB, patch)
2010-09-13 09:45 PDT, Hans Wennborg
no flags Details | Formatted Diff | Diff
Rebase (96.80 KB, patch)
2010-09-14 08:20 PDT, Hans Wennborg
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hans Wennborg 2010-09-10 08:23:23 PDT
Rebaseline DeviceOrientation related layout tests for Chromium.
Comment 1 Hans Wennborg 2010-09-10 08:50:30 PDT
Created attachment 67191 [details]
Patch
Comment 2 Jeremy Orlow 2010-09-10 09:15:51 PDT
Dimitri, can you take a look at this?  This matches what Android has checked in, but the more that I look at it, it feels wrong.  Haven't we in the past avoided needing to check in baselines for property-inheritance?  Also, what about the object vs. function stuff, that's expected, right?
Comment 3 Dimitri Glazkov (Google) 2010-09-10 09:23:43 PDT
Comment on attachment 67191 [details]
Patch

yes, please let's avoid forking fast/dom/prototype-inheritance.html expectations.
Comment 4 Hans Wennborg 2010-09-10 09:38:11 PDT
(In reply to comment #3)
> (From update of attachment 67191 [details])
> yes, please let's avoid forking fast/dom/prototype-inheritance.html expectations.

Ok. Will try to un-fork it on Monday. (Note to self: it was last un-forked in http://trac.webkit.org/changeset/59476.)
Comment 5 Jeremy Orlow 2010-09-10 10:18:05 PDT
Does the rest look reasonable to you though, Dimitri?
Comment 6 Dimitri Glazkov (Google) 2010-09-10 10:19:12 PDT
(In reply to comment #5)
> Does the rest look reasonable to you though, Dimitri?

Yep.
Comment 7 Hans Wennborg 2010-09-13 09:45:10 PDT
Created attachment 67418 [details]
Patch
Comment 8 Hans Wennborg 2010-09-13 09:50:08 PDT
Taking a new stab at this. There seems to have been three versions of expectations for prototype-inheritance:

LayoutTests/fast/dom/prototype-inheritance-expected.txt, i.e. the main WebKit one

LayoutTests/platform/chromium/fast/dom/prototype-inheritance-expected.txt
LayoutTests/platform/chromium-win/fast/dom/prototype-inheritance-expected.txt
LayoutTests/platform/chromium-mac/fast/dom/prototype-inheritance-expected.txt

Dropping the last two ones, and updating the Chromium one to match the main WebKit one. And adding suppressions for IDB stuff etc. to the .js file.
Comment 9 Hans Wennborg 2010-09-14 06:40:32 PDT
Ping?
Comment 10 Jeremy Orlow 2010-09-14 06:47:45 PDT
Comment on attachment 67418 [details]
Patch

r=me
Comment 11 Hans Wennborg 2010-09-14 08:20:15 PDT
Created attachment 67554 [details]
Rebase

Rebase. Adding 'Flags' to list of ignored properties.
Comment 12 Jeremy Orlow 2010-09-14 08:23:04 PDT
you already have an r+.  just land it unless something substantial changed
Comment 13 Hans Wennborg 2010-09-14 08:31:13 PDT
Comment on attachment 67554 [details]
Rebase

Clearing flags on attachment: 67554

Committed r67471: <http://trac.webkit.org/changeset/67471>
Comment 14 Hans Wennborg 2010-09-14 08:31:23 PDT
All reviewed patches have been landed.  Closing bug.