Rebaseline DeviceOrientation related layout tests for Chromium.
Created attachment 67191 [details] Patch
Dimitri, can you take a look at this? This matches what Android has checked in, but the more that I look at it, it feels wrong. Haven't we in the past avoided needing to check in baselines for property-inheritance? Also, what about the object vs. function stuff, that's expected, right?
Comment on attachment 67191 [details] Patch yes, please let's avoid forking fast/dom/prototype-inheritance.html expectations.
(In reply to comment #3) > (From update of attachment 67191 [details]) > yes, please let's avoid forking fast/dom/prototype-inheritance.html expectations. Ok. Will try to un-fork it on Monday. (Note to self: it was last un-forked in http://trac.webkit.org/changeset/59476.)
Does the rest look reasonable to you though, Dimitri?
(In reply to comment #5) > Does the rest look reasonable to you though, Dimitri? Yep.
Created attachment 67418 [details] Patch
Taking a new stab at this. There seems to have been three versions of expectations for prototype-inheritance: LayoutTests/fast/dom/prototype-inheritance-expected.txt, i.e. the main WebKit one LayoutTests/platform/chromium/fast/dom/prototype-inheritance-expected.txt LayoutTests/platform/chromium-win/fast/dom/prototype-inheritance-expected.txt LayoutTests/platform/chromium-mac/fast/dom/prototype-inheritance-expected.txt Dropping the last two ones, and updating the Chromium one to match the main WebKit one. And adding suppressions for IDB stuff etc. to the .js file.
Ping?
Comment on attachment 67418 [details] Patch r=me
Created attachment 67554 [details] Rebase Rebase. Adding 'Flags' to list of ignored properties.
you already have an r+. just land it unless something substantial changed
Comment on attachment 67554 [details] Rebase Clearing flags on attachment: 67554 Committed r67471: <http://trac.webkit.org/changeset/67471>
All reviewed patches have been landed. Closing bug.