Bug 4554 - run-webkit-test --svg crashes if build configuration == Development
Summary: run-webkit-test --svg crashes if build configuration == Development
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Major
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-08-21 03:37 PDT by Tobias Lidskog
Modified: 2005-08-22 11:54 PDT (History)
0 users

See Also:


Attachments
Fix, adds FE_QUARTZ_CHECK_INPUT checks where necessary (2.09 KB, patch)
2005-08-22 01:59 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff
svg that will crash even with fixes in previous diff (2.17 KB, text/plain)
2005-08-22 06:51 PDT, Tobias Lidskog
no flags Details
Added a few additional null checks (2.84 KB, patch)
2005-08-22 06:52 PDT, Tobias Lidskog
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Lidskog 2005-08-21 03:37:05 PDT
If WebCore+SVG is built with configuration Development the svg layout tests will crash. 

Thread 0 Crashed:
0   WebCore+SVG        	0x012af64c KWQReportBlockedException(KWQNSHandler&) + 108 
(KWQExceptions.mm:34)
1   WebCore+SVG        	0x015e70e0 KCanvasFEMergeQuartz::getCIFilter(KCanvasFilterQuartz*) const 
+ 632 (KCanvasFilterQuartz.mm:553)
2   WebCore+SVG        	0x015e5124 KCanvasFilterQuartz::getCIFilterStack(CIImage*) + 288 
(KCanvasFilterQuartz.mm:195)
...

The solution is to insert the following two lines in KCanvasFilterQuartz.mm, 
KCanvasFEMergeQuartz::getCIFilter:
FE_QUARTZ_CHECK_INPUT(inputImage);
FE_QUARTZ_CHECK_INPUT(previousOutput);
after [filter setDefaults];

I could upload a patch, but right now I have another change submitted for the same file (#4550).
Comment 1 Eric Seidel (no email) 2005-08-21 15:06:06 PDT
I have a patch for this already locally. 
Comment 2 Eric Seidel (no email) 2005-08-22 01:59:21 PDT
Created attachment 3506 [details]
Fix, adds FE_QUARTZ_CHECK_INPUT checks where necessary
Comment 3 Tobias Lidskog 2005-08-22 06:51:26 PDT
Created attachment 3514 [details]
svg that will crash even with fixes in previous diff

A few null checks are still missing, will upload updated patch
Comment 4 Tobias Lidskog 2005-08-22 06:52:59 PDT
Created attachment 3515 [details]
Added a few additional null checks

Added some additional null checks, the attached svg file won't crash with this
patch applied.
Comment 5 Eric Seidel (no email) 2005-08-22 11:47:52 PDT
Comment on attachment 3515 [details]
Added a few additional null checks

Looks good.