Bug 45534 - WebGL: Fix GCC warnings about suggested parentheses around && within ||
Summary: WebGL: Fix GCC warnings about suggested parentheses around && within ||
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-10 05:34 PDT by Andreas Kling
Modified: 2010-09-10 08:51 PDT (History)
4 users (show)

See Also:


Attachments
Proposed patch (3.91 KB, patch)
2010-09-10 05:36 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2010-09-10 05:34:51 PDT
../../../WebCore/html/canvas/WebGLRenderingContext.cpp: In member function ‘WebCore::WebGLGetInfo WebCore::WebGLRenderingContext::getVertexAttrib(long unsigned int, long unsigned int, WebCore::ExceptionCode&)’:
../../../WebCore/html/canvas/WebGLRenderingContext.cpp:1760: error: suggest parentheses around ‘&&’ within ‘||’
../../../WebCore/html/canvas/WebGLRenderingContext.cpp: In member function ‘void WebCore::WebGLRenderingContext::readPixels(long int, long int, long int, long int, long unsigned int, long unsigned int, WebCore::ArrayBufferView*)’:
../../../WebCore/html/canvas/WebGLRenderingContext.cpp:1947: error: suggest parentheses around ‘&&’ within ‘||’
../../../WebCore/html/canvas/WebGLRenderingContext.cpp: In member function ‘void WebCore::WebGLRenderingContext::texParameter(long unsigned int, long unsigned int, float, int, bool)’:
../../../WebCore/html/canvas/WebGLRenderingContext.cpp:2225: error: suggest parentheses around ‘&&’ within ‘||’
../../../WebCore/html/canvas/WebGLRenderingContext.cpp: In member function ‘void WebCore::WebGLRenderingContext::handleNPOTTextures(bool)’:
../../../WebCore/html/canvas/WebGLRenderingContext.cpp:3016: error: suggest parentheses around ‘&&’ within ‘||’
Comment 1 Andreas Kling 2010-09-10 05:36:03 PDT
Created attachment 67170 [details]
Proposed patch
Comment 2 Andreas Kling 2010-09-10 05:54:24 PDT
Comment on attachment 67170 [details]
Proposed patch

Clearing flags on attachment: 67170

Committed r67194: <http://trac.webkit.org/changeset/67194>
Comment 3 Andreas Kling 2010-09-10 05:54:34 PDT
All reviewed patches have been landed.  Closing bug.