Refactor JavaScriptCore memory statistics so that WebKit doesn't need to know about the JIT and other implementation details of JavaScriptCore. Necessary to fix PPC build.
Created attachment 67166 [details] Patch
Attachment 67166 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 JavaScriptCore/runtime/MemoryStatistics.cpp:36: Code inside a namespace should not be indented. [whitespace/indent] [4] JavaScriptCore/runtime/MemoryStatistics.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 2 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 67166 [details] Patch Oops! > +#include "ExecutableAllocator.h" > +#include "JSGlobalData.h" > +#include "RegisterFile.h" > + > + Extra blank line here. > +namespace JSC { > + > + MemoryStatistics memoryStatistics(JSGlobalData* commonGlobalData) This shouldn't be indented. I think that it's nice to put heap and stack/JIT statistics under a common umbrella. But I don't think that it's good to report both global and per-heap statistics via one call. Can it be split in two? > +namespace JSC { > + > + struct MemoryStatistics { This shouldn't be indented. > + MemoryStatistics mStats = memoryStatistics(JSDOMWindow::commonJSGlobalData()); We prefer to not abbreviate words - and "m" is a prefix for member variables! r=me, since we need to fix the build ASAP, but I think that this can be improved a bit later.
Attachment 67166 [details] was posted by a committer and has review+, assigning to Stephanie Lewis for commit.
oops, I forgot to close this bug. Sorry! Landed in http://trac.webkit.org/projects/webkit/changeset/67265