Bug 45516 - [chromium] Chromium mac build should exclude all Skia files in platform/graphics/skia/, not just some
Summary: [chromium] Chromium mac build should exclude all Skia files in platform/graph...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-09 19:59 PDT by James Robinson
Modified: 2010-09-09 20:22 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.72 KB, patch)
2010-09-09 20:00 PDT, James Robinson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2010-09-09 19:59:25 PDT 
[chromium] Chromium mac build should exclude all Skia files in platform/graphics/skia/, not just some
Comment 1 James Robinson 2010-09-09 20:00:39 PDT 
Created attachment 67144 [details]
Patch
Comment 2 James Robinson 2010-09-09 20:02:09 PDT 
This caused http://trac.webkit.org/changeset/67126 to be reverted since PlatformContextSkia.cpp was being compiled in to chromium mac.  I've confirmed locally that this builds chrome.xcodeproj target 'chrome' and all targets in webkit.xcodeproj.
Comment 3 Kenneth Russell 2010-09-09 20:18:57 PDT 
Comment on attachment 67144 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=67144&action=prettypatch

Basically, as long as you've built this locally it seems fine to land. If you haven't built it locally then I wouldn't land it until you've verified the change works.

> WebCore/WebCore.gyp/WebCore.gyp:-1248
> -
There is another exclusion of ../platform/graphics/skia/FontCustomPlatformData.cpp higher up. Should that be removed as well?
Comment 4 James Robinson 2010-09-09 20:22:28 PDT 
Comment on attachment 67144 [details]
Patch

Clearing flags on attachment: 67144

Committed r67155: <http://trac.webkit.org/changeset/67155>
Comment 5 James Robinson 2010-09-09 20:22:32 PDT 
All reviewed patches have been landed.  Closing bug.