[chromium] Clear only the uploaded portion of the software backing store when in mixed mode
Created attachment 67121 [details] Patch
Looks good to me.
Comment on attachment 67121 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=67121&action=prettypatch Looks good overall with a couple of minor issues that can be fixed upon landing. > WebCore/platform/graphics/gpu/Texture.cpp:129 > + for (int y = 0; y < height; y++) { Apparently WebKit style prefers preincrement (++y rather than y++). Note that changing this wouldn't change the functionality of the loop. > WebCore/platform/graphics/skia/PlatformContextSkia.cpp:734 > // Start compositing into the empty canvas. This comment should probably change. > WebCore/platform/graphics/skia/PlatformContextSkia.cpp:818 > + SkRect bounds = {m_softwareDirtyRect.x(), m_softwareDirtyRect.y(), m_softwareDirtyRect.right(), m_softwareDirtyRect.bottom()}; There's a casting operator SkRect() on FloatRect when compiled against Skia.
Committed r67152: <http://trac.webkit.org/changeset/67152>
http://trac.webkit.org/changeset/67152 might have broken Chromium Mac Release The following changes are on the blame list: http://trac.webkit.org/changeset/67152 http://trac.webkit.org/changeset/67149 http://trac.webkit.org/changeset/67150 http://trac.webkit.org/changeset/67151