RESOLVED FIXED 45485
REGRESSION(r67095): Broke GTK+ and Windows (Requested by xan_ on #webkit). 
https://bugs.webkit.org/show_bug.cgi?id=45485
Summary REGRESSION(r67095): Broke GTK+ and Windows (Requested by xan_ on #webkit).
WebKit Review Bot
Reported 2010-09-09 12:33:22 PDT
http://trac.webkit.org/changeset/67095 broke the build: Broke GTK+ and Windows (Requested by xan_ on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear
Attachments
ROLLOUT of r67095 (48.67 KB, patch)
2010-09-09 12:33 PDT, WebKit Review Bot 		xan.lopez: review+
cfleizach: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
WebKit Review Bot
Comment 1 2010-09-09 12:33:32 PDT
Created attachment 67080 [details] ROLLOUT of r67095 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID --ignore-builders where ATTACHMENT_ID is the ID of this attachment.
Xan Lopez
Comment 2 2010-09-09 12:35:14 PDT
Comment on attachment 67080 [details] ROLLOUT of r67095 Perhaps a wrong patch was committed? This one ends up accessing void pointers as RefPtrs and doing .get() on them, among other things, in GTK+ and Windows.
chris fleizach
Comment 3 2010-09-09 12:39:56 PDT
(In reply to comment #2) > (From update of attachment 67080 [details]) > Perhaps a wrong patch was committed? This one ends up accessing void pointers as RefPtrs and doing .get() on them, among other things, in GTK+ and Windows. trying to integrate david's suggestion of using RetainPtr. i'm looking at this now and will fix soon
chris fleizach
Comment 4 2010-09-09 12:48:16 PDT
Comment on attachment 67080 [details] ROLLOUT of r67095 i will fix this now
Note You need to log in before you can comment on or make changes to this bug.