Bug 45484 - REGRESSION (r67102): query-font-size.html fails on qt and gtk builds
Summary: REGRESSION (r67102): query-font-size.html fails on qt and gtk builds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2010-09-09 12:22 PDT by Ryosuke Niwa
Modified: 2010-09-09 19:34 PDT (History)
7 users (show)

See Also:

Attachments
removes the two failing test cases for now (1.20 KB, patch)
2010-09-09 13:30 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
removed computed style's font size instead (9.06 KB, patch)
2010-09-09 13:57 PDT, Ryosuke Niwa 		jamesr: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2010-09-09 12:22:25 PDT 
editing/execCommand/query-font-size-actual.html fails on qt bots:

-manual CSS font-size: 3px	<span style="font-size: 3px">test</span>	1	3px
-manual CSS font-size: 0.2em	<span style="font-size: 0.2em">test</span>	1	9px
+manual CSS font-size: 3px	<span style="font-size: 3px">test</span>	1	5px
+manual CSS font-size: 0.2em	<span style="font-size: 0.2em">test</span>	1	5px

I'm suspecting that 5px is the minimum font size on qts.  But it's weird that 0.2em is translated to 5px in computed style given that other font sizes are identical to other platforms.  This might be a qt-specific bug in computed style.
Comment 1 Ryosuke Niwa 2010-09-09 13:23:27 PDT 
I also broke GTK bots:

-manual CSS font-size: 0.2em	<span style="font-size: 0.2em">test</span>	1	9px
+manual CSS font-size: 0.2em	<span style="font-size: 0.2em">test</span>	1	6px
Comment 2 Ryosuke Niwa 2010-09-09 13:30:16 PDT 
Created attachment 67086 [details]
removes the two failing test cases for now
Comment 3 James Robinson 2010-09-09 13:36:31 PDT 
Comment on attachment 67086 [details]
removes the two failing test cases for now

We came up with better solutions in IRC
Comment 4 Ryosuke Niwa 2010-09-09 13:57:39 PDT 
Created attachment 67092 [details]
removed computed style's font size instead
Comment 5 James Robinson 2010-09-09 14:00:26 PDT 
Comment on attachment 67092 [details]
removed computed style's font size instead

R=me
Comment 6 Ryosuke Niwa 2010-09-09 14:17:42 PDT 
Committed r67116: <http://trac.webkit.org/changeset/67116>
Comment 7 WebKit Review Bot 2010-09-09 19:34:32 PDT 
http://trac.webkit.org/changeset/67116 might have broken Leopard Intel Debug (Tests)