Bug 45475 - Mouse-move SVG tests failing on Windows
Summary: Mouse-move SVG tests failing on Windows
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2010-09-09 10:55 PDT by Brian Weinstein
Modified: 2010-09-10 01:09 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Weinstein 2010-09-09 10:55:51 PDT
svg/custom/mouse-move-on-svg-container-standalone.svg
svg/custom/mouse-move-on-svg-container.xhtml
svg/custom/mouse-move-on-svg-root-standalone.svg
svg/custom/mouse-move-on-svg-root.xhtml

Are all failing on Windows, the diffs look like:

--- /home/buildbot/slave/WebKit-BuildSlave/win-debug-tests/build/layout-test-results/svg/custom/mouse-move-on-svg-container-standalone-expected.txt	2010-09-09 17:08:33.171950400 -0700
+++ /home/buildbot/slave/WebKit-BuildSlave/win-debug-tests/build/layout-test-results/svg/custom/mouse-move-on-svg-container-standalone-actual.txt	2010-09-09 17:08:33.170950300 -0700
@@ -7,4 +7,4 @@
     RenderSVGText {text} at (48,36) size 304x18 contains 1 chunk(s)
       RenderSVGInlineText {#text} at (0,0) size 304x18
         chunk 1 (middle anchor) text run 1 at (48.50,50.00) startOffset 0 endOffset 49 width 303.00: "The circle should stay in the bottom-right corner"
-caret: position 49 of child 0 {#text} of child 3 {text} of child 0 {svg} of document
+caret: position 24 of child 0 {#text} of child 3 {text} of child 0 {svg} of document

They all have the wrong caret position. I will look into when these started failing.
Comment 1 Brian Weinstein 2010-09-09 11:00:32 PDT
<rdar://problem/8411647>
Comment 2 Brian Weinstein 2010-09-09 13:58:11 PDT
Failing results landed in http://trac.webkit.org/projects/webkit/changeset/67113, but I'd like an idea why they are failing/or if these results are actually a progression (which I doubt).
Comment 3 Nikolas Zimmermann 2010-09-09 23:53:55 PDT
(In reply to comment #2)
> Failing results landed in http://trac.webkit.org/projects/webkit/changeset/67113, but I'd like an idea why they are failing/or if these results are actually a progression (which I doubt).

It's not a regression, nor a progression. The caret dumping for these SVG tests are irrelevant -- we don't have or use a caret at all in SVG.

It's related to the fact, that the outermost <svg> now receives events (which has been fixed in the aforementioned revision).

You can just update them.
Comment 4 Brian Weinstein 2010-09-09 23:59:12 PDT
(In reply to comment #3)
> (In reply to comment #2)
> > Failing results landed in http://trac.webkit.org/projects/webkit/changeset/67113, but I'd like an idea why they are failing/or if these results are actually a progression (which I doubt).
> 
> It's not a regression, nor a progression. The caret dumping for these SVG tests are irrelevant -- we don't have or use a caret at all in SVG.
> 
> It's related to the fact, that the outermost <svg> now receives events (which has been fixed in the aforementioned revision).
> 
> You can just update them.

Ok, they're updated, so I can just close out the bug? Any idea what would cause the results to be different on Windows vs. the Mac?
Comment 5 Nikolas Zimmermann 2010-09-10 01:09:41 PDT
(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > Failing results landed in http://trac.webkit.org/projects/webkit/changeset/67113, but I'd like an idea why they are failing/or if these results are actually a progression (which I doubt).
> > 
> > It's not a regression, nor a progression. The caret dumping for these SVG tests are irrelevant -- we don't have or use a caret at all in SVG.
> > 
> > It's related to the fact, that the outermost <svg> now receives events (which has been fixed in the aforementioned revision).
> > 
> > You can just update them.
> 
> Ok, they're updated, so I can just close out the bug? Any idea what would cause the results to be different on Windows vs. the Mac?

Oh, I wasn't aware the differences between win & mac, I thought it's just new win baseline vs. old win baseline. You could try disabling the caret dumping at all for SVG, as it doesn't make sense for us.
Or you could really try to find out what's causing the difference, but honestly I have no idea.