Bug 45471 - Factor out the NestingLevelIncrementer
Summary: Factor out the NestingLevelIncrementer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Tony Gentilcore
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-09 10:43 PDT by Tony Gentilcore
Modified: 2010-09-10 09:03 PDT (History)
3 users (show)

See Also:

Attachments
Patch (11.15 KB, patch)
2010-09-09 10:44 PDT, Tony Gentilcore 		eric: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Gentilcore 2010-09-09 10:43:36 PDT 
Factor out the NestingLevelIncrementer
Comment 1 Tony Gentilcore 2010-09-09 10:44:22 PDT 
Created attachment 67057 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-09-09 11:02:31 PDT 
Comment on attachment 67057 [details]
Patch

LGTM.
Comment 3 WebKit Commit Bot 2010-09-10 04:16:55 PDT 
Comment on attachment 67057 [details]
Patch

Rejecting patch 67057 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 1
Last 500 characters of output:
/project.pbxproj
Hunk #1 succeeded at 2444 (offset 6 lines).
Hunk #2 succeeded at 8348 (offset 21 lines).
Hunk #3 succeeded at 14498 (offset 36 lines).
Hunk #4 FAILED at 20506.
1 out of 4 hunks FAILED -- saving rejects to file WebCore/WebCore.xcodeproj/project.pbxproj.rej
patching file WebCore/html/parser/HTMLDocumentParser.cpp
patching file WebCore/html/parser/HTMLDocumentParser.h
patching file WebCore/html/parser/HTMLScriptRunner.cpp
patching file WebCore/html/parser/NestingLevelIncrementer.h

Full output: http://queues.webkit.org/results/3946363
Comment 4 Tony Gentilcore 2010-09-10 09:03:43 PDT 
Committed r67204: <http://trac.webkit.org/changeset/67204>