RESOLVED FIXED 45469
Add media element logging 
https://bugs.webkit.org/show_bug.cgi?id=45469
Summary Add media element logging
Eric Carlson
Reported 2010-09-09 10:31:13 PDT
HTMLMediaElement should WebCore's logging facilities to make debugging some types or problems easier.
Attachments
Proposed patch (25.44 KB, patch)
2010-09-09 11:14 PDT, Eric Carlson 		cmarrin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2010-09-09 11:14:28 PDT
Created attachment 67067 [details] Proposed patch
WebKit Review Bot
Comment 2 2010-09-09 11:17:05 PDT
Attachment 67067 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/html/HTMLMediaElement.cpp:894: An else should appear on the same line as the preceding } [whitespace/newline] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Marrin
Comment 3 2010-09-09 14:00:22 PDT
Comment on attachment 67067 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=67067&action=prettypatch r=me as long as you fix the style issue.
Eric Carlson
Comment 4 2010-09-09 14:08:13 PDT
http://trac.webkit.org/changeset/67114
Note You need to log in before you can comment on or make changes to this bug.