Bug 45462 - Application cache directory should be checked before sending to the web process
Summary: Application cache directory should be checked before sending to the web process
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-09 09:16 PDT by Balazs Kelemen
Modified: 2010-09-10 22:21 PDT (History)
3 users (show)

See Also:

Attachments
proposed patch (1.68 KB, patch)
2010-09-09 09:25 PDT, Balazs Kelemen 		no flags Details | Formatted Diff | Diff
proposed patch (1.68 KB, patch)
2010-09-09 09:45 PDT, Balazs Kelemen 		no flags Details | Formatted Diff | Diff
proposed patch (1.67 KB, patch)
2010-09-10 09:44 PDT, Balazs Kelemen 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Balazs Kelemen 2010-09-09 09:16:03 PDT 
If the platform does not implements WebContext::applicationCacheDirectory (returns with null string) then the WebProcess asserts in ApplicationCacheStorage::setCacheDirectory. Since this is an optional feature we should check the value before sending it to the WebProcess.
Comment 1 Balazs Kelemen 2010-09-09 09:25:44 PDT 
Created attachment 67044 [details]
proposed patch
Comment 2 Balazs Kelemen 2010-09-09 09:45:14 PDT 
Created attachment 67047 [details]
proposed patch

Check emptiness instead of null value since it makes more sense (and includes the null case).
Comment 3 Balazs Kelemen 2010-09-10 09:44:54 PDT 
Created attachment 67196 [details]
proposed patch

I am thoughtless. One more typo fix was needed.
Comment 4 Andreas Kling 2010-09-10 10:14:11 PDT 
Comment on attachment 67196 [details]
proposed patch

r=me
Comment 5 WebKit Commit Bot 2010-09-10 22:21:46 PDT 
Comment on attachment 67196 [details]
proposed patch

Clearing flags on attachment: 67196

Committed r67278: <http://trac.webkit.org/changeset/67278>
Comment 6 WebKit Commit Bot 2010-09-10 22:21:51 PDT 
All reviewed patches have been landed.  Closing bug.