Bug 45459 - [Qt] MiniBrowser does not starts properly
Summary: [Qt] MiniBrowser does not starts properly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-09 08:07 PDT by Balazs Kelemen
Modified: 2010-09-09 09:02 PDT (History)
1 user (show)

See Also:


Attachments
proposed patch (1.84 KB, patch)
2010-09-09 08:11 PDT, Balazs Kelemen
no flags Details | Formatted Diff | Diff
proposed patch (1.79 KB, patch)
2010-09-09 08:28 PDT, Balazs Kelemen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Balazs Kelemen 2010-09-09 08:07:37 PDT
The faulty code is in main.cpp:
BrowserWindow* window = 0;
foreach (QString url, urls) {
    window = new BrowserWindow();
    window->newWindow(url);

The firstly created BrowserWindow is never shown so it just leaves in the memory and feel boring.
Comment 1 Balazs Kelemen 2010-09-09 08:11:20 PDT
Created attachment 67033 [details]
proposed patch
Comment 2 Balazs Kelemen 2010-09-09 08:28:03 PDT
Created attachment 67038 [details]
proposed patch

Removed unnecessary newWindow->show() call.
Comment 3 Andreas Kling 2010-09-09 08:56:01 PDT
Comment on attachment 67038 [details]
proposed patch

> +    resize(960, 640);

This is now done both in the constructor and newWindow(). You can remove it from newWindow().

r=me with that changed
Comment 4 Csaba Osztrogonác 2010-09-09 09:02:37 PDT
(In reply to comment #3)
> (From update of attachment 67038 [details])
> > +    resize(960, 640);
> 
> This is now done both in the constructor and newWindow(). You can remove it from newWindow().
> 
> r=me with that changed

Manually landed in http://trac.webkit.org/changeset/67089 with this change.