Bug 45458 - [Qt] always send an Accept header
Summary: [Qt] always send an Accept header
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2010-09-09 08:05 PDT by Robert Hogan
Modified: 2010-09-09 14:39 PDT (History)
1 user (show)

See Also:

Attachments
Patch (3.20 KB, patch)
2010-09-09 08:13 PDT, Robert Hogan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Hogan 2010-09-09 08:05:44 PDT 
See https://bugs.webkit.org/show_bug.cgi?id=33242

Ensure QtWebKit always sends an Accept header. This is required for compatibility with sites that expect the header in requests for subresources. When loading subresources, kov reports that "Safari seems to send an Accept header; Chromium sends Accept: */*, and works. Firefox sends a more specific header saying it prefers image/png, but accepts any image/* type. I guess it decided that because the resource is being loaded from an <img> tag."
Comment 1 Robert Hogan 2010-09-09 08:13:15 PDT 
Created attachment 67036 [details]
Patch
Comment 2 Andreas Kling 2010-09-09 08:30:02 PDT 
Comment on attachment 67036 [details]
Patch

Nice! r=me
Comment 3 WebKit Commit Bot 2010-09-09 14:39:34 PDT 
Comment on attachment 67036 [details]
Patch

Clearing flags on attachment: 67036

Committed r67118: <http://trac.webkit.org/changeset/67118>
Comment 4 WebKit Commit Bot 2010-09-09 14:39:39 PDT 
All reviewed patches have been landed.  Closing bug.