In order to fix the bug 34564, we must isolate the code to find the special common ancestor into a function.
Created attachment 67014 [details] Patch
Comment on attachment 67014 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=67014&action=prettypatch > WebCore/editing/markup.cpp:961 > + Node* specialCommonAncestor = 0; > + if (shouldAnnotate == AnnotateForInterchange) { > + specialCommonAncestor = ancestorToRetainStructureAndAppearance(commonAncestor); Nit: You may want to copy the comment that was around here about which ancestor you want to include. It's not obvious why we might want the specialCommonAncestor (ie., what makes it special). Maybe the comment should just go above this function.
Thanks for the review. Sorry about a delayed commit. I had to push regression fix first. (In reply to comment #2) > (From update of attachment 67014 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=67014&action=prettypatch > > > WebCore/editing/markup.cpp:961 > > + Node* specialCommonAncestor = 0; > > + if (shouldAnnotate == AnnotateForInterchange) { > > + specialCommonAncestor = ancestorToRetainStructureAndAppearance(commonAncestor); > Nit: You may want to copy the comment that was around here about which ancestor you want to include. It's not obvious why we might want the specialCommonAncestor (ie., what makes it special). Maybe the comment should just go above this function. Will do.
Committed r67176: <http://trac.webkit.org/changeset/67176>
http://trac.webkit.org/changeset/67176 might have broken Qt Linux Release