RESOLVED FIXED 45437
[WML] Add a parameter to fix build break. 
https://bugs.webkit.org/show_bug.cgi?id=45437
Summary [WML] Add a parameter to fix build break.
Gyuyoung Kim
Reported 2010-09-08 21:17:45 PDT
In WMLSelectElement.h, the setSelectedIndexByUser() needs to have one more parameter. Because, parent class's setSelectedIndexByUser() has one more param. In SelectElement.h, => virtual void setSelectedIndexByUser(int index, bool deselect = true, bool fireOnChangeNow = false, bool allowMultipleSelection = false) = 0; In WMLSelectElement.h, => virtual void setSelectedIndexByUser(int index, bool deselect = true, bool fireOnChangeNow = false); However, the setSelectedIndexByUser's implementation has the param. It seems to me that he didn't consider wml header file when the patch owner make his patch.
Attachments
Patch (1.30 KB, patch)
2010-09-08 21:20 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2010-09-08 21:20:18 PDT
Created attachment 66995 [details] Patch
Dirk Schulze
Comment 2 2010-09-08 23:55:50 PDT
Comment on attachment 66995 [details] Patch r=me
WebKit Commit Bot
Comment 3 2010-09-09 02:25:15 PDT
Comment on attachment 66995 [details] Patch Clearing flags on attachment: 66995 Committed r67072: <http://trac.webkit.org/changeset/67072>
WebKit Commit Bot
Comment 4 2010-09-09 02:25:19 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.