Bug 45437 - [WML] Add a parameter to fix build break.
Summary: [WML] Add a parameter to fix build break.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-08 21:17 PDT by Gyuyoung Kim
Modified: 2010-09-09 02:25 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.30 KB, patch)
2010-09-08 21:20 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2010-09-08 21:17:45 PDT 
In WMLSelectElement.h, the setSelectedIndexByUser() needs to have one more parameter. Because, parent class's setSelectedIndexByUser() has one more param.

In SelectElement.h,

=>  virtual void setSelectedIndexByUser(int index, bool deselect = true, bool fireOnChangeNow = false, bool allowMultipleSelection = false) = 0;

In WMLSelectElement.h,
=> virtual void setSelectedIndexByUser(int index, bool deselect = true, bool fireOnChangeNow = false);

However, the setSelectedIndexByUser's implementation has the param. It seems to me that he didn't consider wml header file when the patch owner make his patch.
Comment 1 Gyuyoung Kim 2010-09-08 21:20:18 PDT 
Created attachment 66995 [details]
Patch
Comment 2 Dirk Schulze 2010-09-08 23:55:50 PDT 
Comment on attachment 66995 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2010-09-09 02:25:15 PDT 
Comment on attachment 66995 [details]
Patch

Clearing flags on attachment: 66995

Committed r67072: <http://trac.webkit.org/changeset/67072>
Comment 4 WebKit Commit Bot 2010-09-09 02:25:19 PDT 
All reviewed patches have been landed.  Closing bug.