Bug 45433 - [EFL] Fix duplicate gstreamer macro in CMakeListEfl.txt
Summary: [EFL] Fix duplicate gstreamer macro in CMakeListEfl.txt
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-08 18:31 PDT by Gyuyoung Kim
Modified: 2010-09-09 23:02 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.32 KB, patch)
2010-09-08 18:35 PDT, Gyuyoung Kim 		tonikitoo: review+
tonikitoo: commit-queue-
Details | Formatted Diff | Diff
Patch (1.33 KB, patch)
2010-09-08 19:08 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2010-09-08 18:31:47 PDT 
In WebKit/efl/CMakeListEfl.txt, duplicated ENABLE_VIDEO macros were added. So, I remove unnecessary thing.

IF (ENABLE_VIDEO)
 LIST(APPEND WebKit_INCLUDE_DIRECTORIES
     "${WEBCORE_DIR}/platform/graphics/gstreamer"
      ${Gstreamer-App_INCLUDE_DIRS}
      ${Gstreamer-Interfaces_INCLUDE_DIRS}
      ${Gstreamer-Pbutils_INCLUDE_DIRS}
      ${Gstreamer-Video_INCLUDE_DIRS}
)
ENDIF()

IF (ENABLE_VIDEO)
LIST(APPEND WebKit_INCLUDE_DIRECTORIES
    "${WEBCORE_DIR}/platform/graphics/gstreamer"
     ${GStreamer-App_INCLUDE_DIRS}
     ${GStreamer-Interfaces_INCLUDE_DIRS}
     ${GStreamer-Pbutils_INCLUDE_DIRS}
...
Comment 1 Gyuyoung Kim 2010-09-08 18:35:28 PDT 
Created attachment 66986 [details]
Patch
Comment 2 Antonio Gomes 2010-09-08 18:55:29 PDT 
Comment on attachment 66986 [details]
Patch

Fix the indentation in the changelog before landing.
Comment 3 Gyuyoung Kim 2010-09-08 19:08:05 PDT 
Created attachment 66989 [details]
Patch

Oops, sorry. I fix it. :)

Thanks.
Comment 4 WebKit Commit Bot 2010-09-09 02:06:38 PDT 
Comment on attachment 66989 [details]
Patch

Clearing flags on attachment: 66989

Committed r67071: <http://trac.webkit.org/changeset/67071>
Comment 5 Gyuyoung Kim 2010-09-09 23:02:25 PDT 
This bug's patch was landed to mainline. So, I change this bug's status with Resolved.