Bug 45429 - WebKit2 needs a way to box numbers (for Array, Dictionary, etc.)
Summary: WebKit2 needs a way to box numbers (for Array, Dictionary, etc.)
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
Keywords: InRadar
Depends on:
Reported: 2010-09-08 18:01 PDT by Sam Weinig
Modified: 2010-09-08 20:22 PDT (History)
3 users (show)

See Also:

Patch (22.49 KB, patch)
2010-09-08 18:04 PDT, Sam Weinig
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2010-09-08 18:01:16 PDT
WebKit2 needs a way to box numbers (for Array, Dictionary, etc.)
Comment 1 Sam Weinig 2010-09-08 18:01:38 PDT
Comment 2 Sam Weinig 2010-09-08 18:04:54 PDT
Created attachment 66977 [details]
Comment 3 WebKit Review Bot 2010-09-08 18:08:54 PDT
Attachment 66977 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/UIProcess/API/C/WKNumber.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/UIProcess/API/C/WKNumber.cpp:29:  Alphabetical sorting problem.  [build/include_order] [4]
WebKit2/UIProcess/API/C/WKAPICast.h:71:  More than one command on the same line  [whitespace/newline] [4]
WebKit2/UIProcess/API/C/WKAPICast.h:99:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 4 in 12 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 mitz 2010-09-08 18:20:36 PDT
Comment on attachment 66977 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=66977&action=prettypatch

extra bad. r=me

> WebKit2/ChangeLog:34
> +2010-09-08  Sam Weinig  <sam@webkit.org>

> WebKit2/UIProcess/API/C/WKNumber.cpp:29
> +#include "WebNumber.h"
> +#include "WKAPICast.h"
Comment 5 Sam Weinig 2010-09-08 19:26:34 PDT
Landed in r67047.
Comment 6 WebKit Review Bot 2010-09-08 20:22:23 PDT
http://trac.webkit.org/changeset/67047 might have broken GTK Linux 32-bit Debug
The following changes are on the blame list: