Bug 45429 – WebKit2 needs a way to box numbers (for Array, Dictionary, etc.)

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Sam Weinig]

WebKit2 needs a way to box numbers (for Array, Dictionary, etc.)

[Sam Weinig]

<rdar://problem/8408844>

[Sam Weinig]

Created attachment 66977 [details]
Patch

[WebKit Review Bot]

Attachment 66977 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/UIProcess/API/C/WKNumber.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/UIProcess/API/C/WKNumber.cpp:29:  Alphabetical sorting problem.  [build/include_order] [4]
WebKit2/UIProcess/API/C/WKAPICast.h:71:  More than one command on the same line  [whitespace/newline] [4]
WebKit2/UIProcess/API/C/WKAPICast.h:99:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 4 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 66977 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=66977&action=prettypatch

extra bad. r=me

> WebKit2/ChangeLog:34
> [phone]  Sam Weinig  <[e-mail]>
extra!

> WebKit2/UIProcess/API/C/WKNumber.cpp:29
> +#include "WebNumber.h"
> +#include "WKAPICast.h"
bad

[Sam Weinig]

Landed in r67047.

[WebKit Review Bot]

http://trac.webkit.org/changeset/67047 might have broken GTK Linux 32-bit Debug
The following changes are on the blame list:
http://trac.webkit.org/changeset/67045
http://trac.webkit.org/changeset/67046
http://trac.webkit.org/changeset/67047