WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
45415
[chromium] Always do 2d canvas clearRect() in hardware
https://bugs.webkit.org/show_bug.cgi?id=45415
Summary
[chromium] Always do 2d canvas clearRect() in hardware
James Robinson
Reported
2010-09-08 14:51:19 PDT
[chromium] Always do 2d canvas clearRect() in hardware
Attachments
Patch
(2.03 KB, patch)
2010-09-08 14:57 PDT
,
James Robinson
kbr
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
James Robinson
Comment 1
2010-09-08 14:57:50 PDT
Created
attachment 66946
[details]
Patch
James Robinson
Comment 2
2010-09-08 14:58:46 PDT
This patch fixes fuzz on the edge of the FPS meter of the IE test drive pages caused by the end of the white FPS bar extending past the edge of the gradient.
James Robinson
Comment 3
2010-09-08 16:39:58 PDT
kling in IRC pointed out that we should _not_ apply a shadow to clearRect(), even though CoreGraphics does. There's still the issue that clearRect() is supposed to only clear within the active clipping region (this overclears), so this isn't patch isn't perfect, but it's better than what we do currently.
Kenneth Russell
Comment 4
2010-09-08 16:49:26 PDT
Comment on
attachment 66946
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=66946&action=prettypatch
Looks OK.
James Robinson
Comment 5
2010-09-08 16:54:56 PDT
Committed
r67039
: <
http://trac.webkit.org/changeset/67039
>
WebKit Review Bot
Comment 6
2010-09-08 18:49:09 PDT
http://trac.webkit.org/changeset/67039
might have broken SnowLeopard Intel Release (Tests) The following changes are on the blame list:
http://trac.webkit.org/changeset/67033
http://trac.webkit.org/changeset/67034
http://trac.webkit.org/changeset/67035
http://trac.webkit.org/changeset/67036
http://trac.webkit.org/changeset/67037
http://trac.webkit.org/changeset/67038
http://trac.webkit.org/changeset/67039
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug