Bug 45406 - Make FocusController::focusedOrMainFrame method const
Summary: Make FocusController::focusedOrMainFrame method const
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Frames (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P3 Normal
Assignee: Antonio Gomes
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-08 12:10 PDT by Antonio Gomes
Modified: 2010-09-08 15:20 PDT (History)
2 users (show)

See Also:


Attachments
patch v1. (2.27 KB, patch)
2010-09-08 12:22 PDT, Antonio Gomes
no flags Details | Formatted Diff | Diff
patch v1.1 (2.27 KB, patch)
2010-09-08 12:26 PDT, Antonio Gomes
no flags Details | Formatted Diff | Diff
(committed with r67025, r=dbates)patch v1.2 (do not review - checking with the bots). (3.01 KB, patch)
2010-09-08 14:54 PDT, Antonio Gomes
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Gomes 2010-09-08 12:10:24 PDT
Originally this method could not be const because it was setting class member objects. http://trac.webkit.org/changeset/19197 changed that.

Now method just internally call two other already const methods. Making this const makes it possible caller of it to also be const.

Patching coming...
Comment 1 Antonio Gomes 2010-09-08 12:22:52 PDT
Created attachment 66926 [details]
patch v1.
Comment 2 Antonio Gomes 2010-09-08 12:26:02 PDT
Created attachment 66927 [details]
patch v1.1

Fixed a OOPS in the changelog.
Comment 3 Eric Seidel (no email) 2010-09-08 12:45:11 PDT
Attachment 66927 [details] did not build on mac:
Build output: http://queues.webkit.org/results/3952276
Comment 4 Antonio Gomes 2010-09-08 12:54:05 PDT
(In reply to comment #3)
> Attachment 66927 [details] did not build on mac:
> Build output: http://queues.webkit.org/results/3952276

/Users/eseidel/Projects/MacEWS/WebKitBuild/Release/WebCore.framework/Versions/A/WebCore
Undefined symbols:
  "__ZN7WebCore15FocusController18focusedOrMainFrameEv", referenced from:
     -exported_symbols_list command line option
ld: symbol(s) not found
collect2: ld returned 1 exit status
Comment 5 Daniel Bates 2010-09-08 14:08:51 PDT
Comment on attachment 66927 [details]
patch v1.1

You will need to update WebCore/WebCore.exp.in to reflect the new symbol. In particular, substitute __ZNK7WebCore15FocusController18focusedOrMainFrameEv for  __ZN7WebCore15FocusController18focusedOrMainFrameEv.

r=me.
Comment 6 Antonio Gomes 2010-09-08 14:54:19 PDT
Created attachment 66945 [details]
(committed with r67025, r=dbates)patch v1.2 (do not review - checking with the bots).

Thank you, Dan. Double checking with the build bots if all goes fine. I will commit manually if it does.
Comment 7 Antonio Gomes 2010-09-08 15:19:32 PDT
Comment on attachment 66945 [details]
(committed with r67025, r=dbates)patch v1.2 (do not review - checking with the bots).

Clearing flags on attachment 66945 [details].

Committed <http://trac.webkit.org/changeset/67025>