Bug 45401 - Add Tracing to Regular Expression Code
Summary: Add Tracing to Regular Expression Code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.5
: P2 Enhancement
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-08 11:12 PDT by Michael Saboff
Modified: 2010-09-10 09:40 PDT (History)
1 user (show)

See Also:


Attachments
RegExp Tracing Patch (11.77 KB, patch)
2010-09-08 16:55 PDT, Michael Saboff
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2010-09-08 11:12:55 PDT
Tracing of regular expressions including the original express, number of times used, number of times matched and optional JIT address would be helpful to debug and tune regular expression code.
Comment 1 Michael Saboff 2010-09-08 16:55:12 PDT
Created attachment 66965 [details]
RegExp Tracing Patch
Comment 2 WebKit Commit Bot 2010-09-09 16:59:43 PDT
Comment on attachment 66965 [details]
RegExp Tracing Patch

Rejecting patch 66965 from commit-queue.

msaboff@apple.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 3 WebKit Commit Bot 2010-09-09 17:42:10 PDT
Comment on attachment 66965 [details]
RegExp Tracing Patch

Rejecting patch 66965 from commit-queue.

msaboff@apple.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 4 WebKit Commit Bot 2010-09-09 19:11:56 PDT
Comment on attachment 66965 [details]
RegExp Tracing Patch

Clearing flags on attachment: 66965

Committed r67146: <http://trac.webkit.org/changeset/67146>
Comment 5 WebKit Commit Bot 2010-09-09 19:12:00 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Alexey Proskuryakov 2010-09-10 09:40:00 PDT
+#if ENABLE(REGEXP_TRACING)
+    delete m_rtTraceList;
+#endif

Looks like m_rtTraceList could be an OwnPtr instead.