WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
45394
Canvas: Remove unnecessary null-check of canvas() in getImageData()
https://bugs.webkit.org/show_bug.cgi?id=45394
Summary
Canvas: Remove unnecessary null-check of canvas() in getImageData()
Andreas Kling
Reported
2010-09-08 08:53:03 PDT
We do... ImageBuffer* buffer = canvas() ? canvas()->buffer() : 0; ...but canvas() is already dereferenced earlier in the function so there is no use in checking it for null here.
Attachments
Proposed patch
(1.38 KB, patch)
2010-09-08 08:54 PDT
,
Andreas Kling
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Andreas Kling
Comment 1
2010-09-08 08:54:11 PDT
Created
attachment 66901
[details]
Proposed patch
Andreas Kling
Comment 2
2010-09-08 09:07:08 PDT
Comment on
attachment 66901
[details]
Proposed patch Clearing flags on attachment: 66901 Committed
r66988
: <
http://trac.webkit.org/changeset/66988
>
Andreas Kling
Comment 3
2010-09-08 09:07:18 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug