Bug 45390 – Windows build broken on some locales due to non-ASCII characters in ConditionalMacros.h

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[ljgeneral]

when building webkit revision 66795 in cygwin using webkit/webkit/webkittools/scripts/build-webkit --debug. I get following ouput

Output Window
 	 	
Performing Pre-Build Event...
/usr/bin/bash
复制了 0 个文件
Compiling...
DumpRenderTree.cpp
C:\cygwin\home\hxl\webkit\WebKitLibraries\win\Include\ConditionalMacros.h : error C2220: warning treated as error - no 'object' file generated
C:\cygwin\home\hxl\webkit\WebKitLibraries\win\Include\ConditionalMacros.h : warning C4819: The file contains a character that cannot be represented in the current code page (936). Save the file in Unicode format to prevent data loss
C:\cygwin\home\hxl\webkit\WebKitLibraries\win\Include\ConditionalMacros.h(796) : warning C4819: The file contains a character that cannot be represented in the current code page (936). Save the file in Unicode format to prevent data loss
C:\cygwin\home\hxl\webkit\WebKitLibraries\win\Include\ConditionalMacros.h(1525) : warning C4819: The file contains a character that cannot be represented in the current code page (936). Save the file in Unicode format to prevent data loss
Project : warning PRJ0018 : The following environment variables were not found:
$(PRODUCTION)

My operation system  is Win7,I have got 32bit Microsoft Visual C++ 2005 Express Edition

I try to modify the project property "Treat Warnings As Errors" with "No" in Microsoft Visual C++ 2005 Express Edition And build it again in cygWin.But it doesn't work.How can i do with this error.
Thanks very much.

[Alexey Proskuryakov]

I'm surprised that this didn't come up before. People have fixed similar issues in WebKit code (see e.g. bug 23598), but not in ConditionalMacros.h.

[ljgeneral]

thank you, and could you tell me how I can past this error?

[Adam Roben (:aroben)]

<rdar://problem/8433040>

[Adam Roben (:aroben)]

(In reply to comment #2)
> thank you, and could you tell me how I can past this error?

You could remove the offending characters from your local copy of ConditionalMacros.h.

[ljgeneral]

I opened ConditionalMacros.h in Microsoft Visual C++ 2005 Express Edition and saved it, then rebuild it. it works well. thank you all!