RESOLVED FIXED 45387
[GTK] Implement ContextMenu::itemCount 
https://bugs.webkit.org/show_bug.cgi?id=45387
Summary [GTK] Implement ContextMenu::itemCount
Philippe Normand
Reported 2010-09-08 06:51:06 PDT
Incoming patch
Attachments
itemCount implementation (2.65 KB, patch)
2010-09-08 06:57 PDT, Philippe Normand 		cfleizach: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2010-09-08 06:57:39 PDT
Created attachment 66891 [details] itemCount implementation
Martin Robinson
Comment 2 2010-09-08 12:55:07 PDT
Is there some test this affects?
Philippe Normand
Comment 3 2010-09-09 00:31:26 PDT
Well I was thinking about using this in the ContextMenu::populate method but it can be avoided. Moreover this itemCount() method is virtually unused, from what I could find with git grep... It was even marked as "silly method" at some point ;) So what should we do? Land the one-liner untested or find a use for it and write a test?
chris fleizach
Comment 4 2010-09-10 02:04:34 PDT
Comment on attachment 66891 [details] itemCount implementation > /* > * Copyright (C) 2006, 2007 Apple Inc. All rights reserved. > * Copyright (C) 2008 Christian Dywan <christian@imendio.com> > + * Copyright (C) 2010 Igalia S.L > * > * Redistribution and use in source and binary forms, with or without Coding guidelines state Develop your changes If you make substantive changes to a file, you may wish to add a copyright line for yourself or for the company on whose behalf you work. I don't think this is a substantive change. You should also have a layout test here, especially because new functionality is being exposed
Martin Robinson
Comment 5 2012-05-18 13:33:14 PDT
Looks like this was implemented in r107593.
Note You need to log in before you can comment on or make changes to this bug.