Bug 45366 - Add test for percent height image inside floated element.
Summary: Add test for percent height image inside floated element.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-07 22:40 PDT by Luke Macpherson
Modified: 2010-09-09 04:47 PDT (History)
7 users (show)

See Also:

Attachments
Patch (12.85 KB, patch)
2010-09-07 23:02 PDT, Luke Macpherson 		no flags Details | Formatted Diff | Diff
Patch (3.57 KB, patch)
2010-09-08 23:06 PDT, Luke Macpherson 		no flags Details | Formatted Diff | Diff
Patch (3.44 KB, patch)
2010-09-08 23:45 PDT, Luke Macpherson 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Luke Macpherson 2010-09-07 22:40:38 PDT 
Add test for percent height image inside floated element.
Comment 1 Luke Macpherson 2010-09-07 23:00:12 PDT 
For reference, here is the Chromium bug with screenshots of IE and Firefox.
Comment 3 Luke Macpherson 2010-09-07 23:02:20 PDT 
Created attachment 66844 [details]
Patch
Comment 4 James Robinson 2010-09-08 19:43:47 PDT 
Comment on attachment 66844 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=66844&action=prettypatch

> LayoutTests/fast/images/percent-height-image-expected.txt:5
> +in RenderReplaced::layout
> +hit RenderImage::calcReplacedHeight()
> +hit RenderImage::calcReplacedHeight()
> +in RenderReplaced::layout
> +hit RenderImage::calcReplacedHeight()
looks like some printf()s made it into your output.
Comment 5 David Levin 2010-09-08 19:59:07 PDT 
It sounds like folks are generally agreed that a dump as text would be better.

Also, I think it would be nice if you filed a WebKit bug about the incorrect behavior and referred to that bug in the test output text.
Comment 6 Luke Macpherson 2010-09-08 23:06:24 PDT 
Created attachment 66998 [details]
Patch
Comment 7 James Robinson 2010-09-08 23:32:51 PDT 
Comment on attachment 66998 [details]
Patch

Cool.  Please fix the ChangeLog, but otherwise looks good.

View in context: https://bugs.webkit.org/attachment.cgi?id=66998&action=prettypatch

> LayoutTests/ChangeLog:11
> +        * fast/images/percent-height-image-expected.checksum: Added.
> +        * fast/images/percent-height-image-expected.png: Added.
> +        * fast/images/percent-height-image-expected.txt: Added.
> +        * fast/images/percent-height-image.html: Added.
The checksum/png aren't in this patch any more, remove them from the ChangeLog
Comment 8 Luke Macpherson 2010-09-08 23:45:40 PDT 
Created attachment 67000 [details]
Patch
Comment 9 WebKit Commit Bot 2010-09-09 03:17:07 PDT 
Comment on attachment 67000 [details]
Patch

Clearing flags on attachment: 67000

Committed r67075: <http://trac.webkit.org/changeset/67075>
Comment 10 WebKit Commit Bot 2010-09-09 03:17:12 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 11 WebKit Review Bot 2010-09-09 04:47:32 PDT 
http://trac.webkit.org/changeset/67075 might have broken SnowLeopard Intel Release (Tests)
The following changes are on the blame list:
http://trac.webkit.org/changeset/67075
http://trac.webkit.org/changeset/67076