Bug 45360 – chromium/mac: Fix overrelease in ImageLayerChromium

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Nico Weber]

chromium/mac: Fix overrelease in ImageLayerChromium

[Nico Weber]

Created attachment 66831 [details]
Patch

[Kenneth Russell]

Comment on attachment 66831 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=66831&action=prettypatch

> WebCore/platform/graphics/chromium/ImageLayerChromium.cpp:112
> +    CGColorSpaceRef> colorSpace = CGImageGetColorSpace(cgImage);
Um, does this compile? If not, how was this fix tested?

[Nico Weber]

Created attachment 66835 [details]
Patch

[Nico Weber]

(In reply to comment #2)
> (From update of attachment 66831 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=66831&action=prettypatch
> 
> > WebCore/platform/graphics/chromium/ImageLayerChromium.cpp:112
> > +    CGColorSpaceRef> colorSpace = CGImageGetColorSpace(cgImage);
> Um, does this compile? If not, how was this fix tested?

Oops :-)

I have a very sophisticated system where I do my changes in third_party/WebKit/WebCore for developing / testing and then I have a separate git WebKit checkout I upload my patches from. I copied the patch over to early and then tried to manually redo what I changed to get this to compile. Looks like I missed one place. Fixed.

[Dimitri Glazkov (Google)]

Comment on attachment 66835 [details]
Patch

I _think_ I understand what you're doing here.

[WebKit Commit Bot]

Comment on attachment 66835 [details]
Patch

Clearing flags on attachment: 66835

Committed r67015: <http://trac.webkit.org/changeset/67015>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.