Bug 45356 - test-webkitpy: Fix load error of webkitpy/layout_tests/port/factory_unittest.py on Win32 Python
Summary: test-webkitpy: Fix load error of webkitpy/layout_tests/port/factory_unittest....
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Windows 7
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 45342
  Show dependency treegraph
 
Reported: 2010-09-07 18:54 PDT by Kent Tamura
Modified: 2010-09-08 07:54 PDT (History)
7 users (show)

See Also:


Attachments
Patch (1.53 KB, patch)
2010-09-07 18:58 PDT, Kent Tamura
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2010-09-07 18:54:34 PDT
test-webkitpy: INFO     Suppressing most webkitpy logging while running unit tests.
test-webkitpy: WARNING  You are testing webkitpy with a Python version (2.6.2) higher than the minimum version (2.5) it was meant to support.
webkitpy.test.main: INFO     Excluding: webkitpy.common.checkout.scm_unittest (use --all to include)
Traceback (most recent call last):
  File "./WebKitTools/Scripts/test-webkitpy", line 240, in <module>
    Tester().run_tests(sys.argv)
  File "D:\google-windows-2\chromium-win-release-tests\build\WebKitTools\Scripts\webkitpy\test\main.py", line 129, in run_tests
    unittest.main(argv=sys_argv, module=None)
  File "c:\depot_tools\python_bin\lib\unittest.py", line 816, in __init__
    self.parseArgs(argv)
  File "c:\depot_tools\python_bin\lib\unittest.py", line 843, in parseArgs
    self.createTests()
  File "c:\depot_tools\python_bin\lib\unittest.py", line 849, in createTests
    self.module)
  File "c:\depot_tools\python_bin\lib\unittest.py", line 613, in loadTestsFromNames
    suites = [self.loadTestsFromName(name, module) for name in names]
  File "c:\depot_tools\python_bin\lib\unittest.py", line 584, in loadTestsFromName
    parent, obj = obj, getattr(obj, part)
AttributeError: 'module' object has no attribute 'factory_unittest'
Comment 1 Kent Tamura 2010-09-07 18:58:32 PDT
Created attachment 66827 [details]
Patch
Comment 2 Dirk Pranke 2010-09-07 19:17:29 PDT
Patch LGTM, but I'm not a reviewer. We need a better way of figuring out which unittests should run on a given platform.
Comment 3 Kent Tamura 2010-09-07 19:56:55 PDT
Comment on attachment 66827 [details]
Patch

Clearing flags on attachment: 66827

Committed r66946: <http://trac.webkit.org/changeset/66946>
Comment 4 Kent Tamura 2010-09-07 19:57:03 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 WebKit Review Bot 2010-09-08 07:54:30 PDT
http://trac.webkit.org/changeset/66946 might have broken Leopard Intel Debug (Tests)