Bug 45354 – chromium/mac: Fix crash with compositor due to missing current NSGraphicsContext

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Nico Weber]

chromium/mac: Fix crash with compositor due to missing current NSGraphicsContext

[Nico Weber]

Created attachment 66823 [details]
Patch

[Nico Weber]

Patch also removes some duplicated code.

[Nico Weber]

This is supposed to fix http://crbug.com/54763 btw

[Kenneth Russell]

Comment on attachment 66823 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=66823&action=prettypatch

Looks good to me. Because I've run into the issue that Chromium doesn't define PLATFORM(MAC) I'm surprised that we compile in code in the WebCore/platform/mac directory (LocalCurrentGraphicsContext).

Is there any possibility that LocalCurrentGraphicsContext is leaking its newly created NSGraphicsContext (by leaving it as the current context) if there isn't a current NSGraphicsContext going in to the constructor?

> WebCore/platform/graphics/chromium/ContentLayerChromium.cpp:46
> +
Unneeded newline

[Nico Weber]

Thanks for the review!

(In reply to comment #4)
> (From update of attachment 66823 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=66823&action=prettypatch
> 
> Looks good to me. Because I've run into the issue that Chromium doesn't define PLATFORM(MAC) I'm surprised that we compile in code in the WebCore/platform/mac directory (LocalCurrentGraphicsContext).

We generally build files in mac/ subdirectories. See WebCore/WebCore.gypi for a list of all files we look at and then grep WebCore/WebCore.gyp/WebCore.gyp for "exclude" for stuff we exclude from that long list.

> Is there any possibility that LocalCurrentGraphicsContext is leaking its newly created NSGraphicsContext (by leaving it as the current context) if there isn't a current NSGraphicsContext going in to the constructor?
> 
> > WebCore/platform/graphics/chromium/ContentLayerChromium.cpp:46
> > +
> Unneeded newline

Most files I looked at had a newline between system stuff and webkit stuff.

[WebKit Commit Bot]

Comment on attachment 66823 [details]
Patch

Clearing flags on attachment: 66823

Committed r66975: <http://trac.webkit.org/changeset/66975>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.