Bug 45351 – pushstate-clears-forward-history.html crashes with Chromium DRT

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Mihai Parparita]

pushstate-clears-forward-history.html crashes with Chromium DRT

[Mihai Parparita]

Created attachment 66821 [details]
Patch

[Mihai Parparita]

Dimitri, since you suggested that I look at this, perhaps you can review too :)

Darin, this is mostly a FYI, in case I'm misunderstanding something about popstate firing synchronously and bad things that happen because of that.

[Darin Fisher (:fishd, Google)]

Comment on attachment 66821 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=66821&action=prettypatch

> LayoutTests/fast/loader/stateobjects/popstate-fires-with-page-cache.html:50
> +            setTimeout(function() { testWindow.close(); finishJSTest(); }, 0);
readability nit:

setTimeout(function() {
    testWindow.close();
    finishJSTest();
}, 0);

That way it is easy to set breakpoints too in the JS debugger.

[Mihai Parparita]

Created attachment 66902 [details]
Patch

[Mihai Parparita]

(In reply to comment #3)
> readability nit:
> setTimeout(function() {
>     testWindow.close();
>     finishJSTest();
> }, 0);

Fixed in new version of the patch.

[Dimitri Glazkov (Google)]

Comment on attachment 66902 [details]
Patch

k.

[WebKit Commit Bot]

Comment on attachment 66902 [details]
Patch

Clearing flags on attachment: 66902

Committed r67060: <http://trac.webkit.org/changeset/67060>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.