RESOLVED FIXED 45346
TextDocument doesn't belong in WebCore/loader 
https://bugs.webkit.org/show_bug.cgi?id=45346
Summary TextDocument doesn't belong in WebCore/loader
Adam Barth
Reported 2010-09-07 17:35:41 PDT
TextDocument doesn't belong in WebCore/loader
Attachments
Patch (14.75 KB, patch)
2010-09-07 17:37 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-09-07 17:37:37 PDT
Created attachment 66804 [details] Patch
Eric Seidel (no email)
Comment 2 2010-09-07 17:50:22 PDT
Comment on attachment 66804 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=66804&action=prettypatch Yay!
WebKit Commit Bot
Comment 3 2010-09-07 20:29:22 PDT
Comment on attachment 66804 [details] Patch Rejecting patch 66804 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 1 Last 500 characters of output: Hunk #2 FAILED at 2787. Hunk #3 succeeded at 6225 (offset -4 lines). Hunk #4 FAILED at 8653. Hunk #5 succeeded at 14324 (offset -7 lines). Hunk #6 succeeded at 16575 (offset -12 lines). Hunk #7 succeeded at 20149 (offset -11 lines). Hunk #8 FAILED at 20438. Hunk #9 succeeded at 22668 (offset -14 lines). Hunk #10 FAILED at 22900. 4 out of 10 hunks FAILED -- saving rejects to file WebCore/WebCore.xcodeproj/project.pbxproj.rej rm 'WebCore/loader/TextDocument.cpp' rm 'WebCore/loader/TextDocument.h' Full output: http://queues.webkit.org/results/3909303
Adam Barth
Comment 4 2010-09-08 02:07:10 PDT
Comment on attachment 66804 [details] Patch Clearing flags on attachment: 66804 Committed r66960: <http://trac.webkit.org/changeset/66960>
Adam Barth
Comment 5 2010-09-08 02:07:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.