Bug 45343 - Create TextViewSourceParser
Summary: Create TextViewSourceParser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-07 17:25 PDT by Adam Barth
Modified: 2010-09-08 02:04 PDT (History)
2 users (show)

See Also:

Attachments
Patch (15.99 KB, patch)
2010-09-07 17:28 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-09-07 17:25:33 PDT 
Create TextViewSourceParser
Comment 1 Adam Barth 2010-09-07 17:28:05 PDT 
Created attachment 66796 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-09-07 17:51:16 PDT 
Comment on attachment 66796 [details]
Patch

LGTM.
Comment 3 WebKit Commit Bot 2010-09-07 20:09:58 PDT 
Comment on attachment 66796 [details]
Patch

Rejecting patch 66796 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 1
Last 500 characters of output:
TMLViewSourceDocument.cpp.rej
patching file WebCore/html/parser/HTMLViewSourceParser.cpp
Hunk #1 FAILED at 42.
1 out of 1 hunk FAILED -- saving rejects to file WebCore/html/parser/HTMLViewSourceParser.cpp.rej
patching file WebCore/html/parser/HTMLViewSourceParser.h
Hunk #1 FAILED at 50.
1 out of 1 hunk FAILED -- saving rejects to file WebCore/html/parser/HTMLViewSourceParser.h.rej
patching file WebCore/html/parser/TextViewSourceParser.cpp
patching file WebCore/html/parser/TextViewSourceParser.h

Full output: http://queues.webkit.org/results/3920298
Comment 4 Adam Barth 2010-09-08 02:04:36 PDT 
Comment on attachment 66796 [details]
Patch

Clearing flags on attachment: 66796

Committed r66959: <http://trac.webkit.org/changeset/66959>
Comment 5 Adam Barth 2010-09-08 02:04:41 PDT 
All reviewed patches have been landed.  Closing bug.