Bug 45340 – Support SerializedScriptValue in WebKit2

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Oliver Hunt]

Support SerializedScriptValue in WebKit2

[Oliver Hunt]

Created attachment 66795 [details]
Patch

[WebKit Review Bot]

Attachment 66795 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/UIProcess/API/C/WKSerializedScriptValue.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/UIProcess/API/C/WKAPICast.h:104:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 2 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Oliver Hunt]

Created attachment 66802 [details]
Patch

[WebKit Review Bot]

Attachment 66802 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/UIProcess/API/C/WKSerializedScriptValue.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/UIProcess/API/C/WKAPICast.h:104:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 2 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Sam Weinig]

Comment on attachment 66802 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=66802&action=prettypatch

> WebKit2/UIProcess/API/C/WKAPICast.h:107
>  template<> struct ImplTypeInfo<WebNavigationData*>              { typedef WKNavi
>  template<> struct ImplTypeInfo<WebPageNamespace*>               { typedef WKPageNamespaceRef APIType; };
>  template<> struct ImplTypeInfo<WebPageProxy*>                   { typedef WKPageRef APIType; };
>  template<> struct ImplTypeInfo<WebPreferences*>                 { typedef WKPreferencesRef APIType; };
> +template<> struct ImplTypeInfo<WebSerializedScriptValue*>       { typedef WKSerializedScriptValueRef APIType; };
>  template<> struct ImplTypeInfo<WebString*>                      { typedef WKStringRef APIType; };
>  template<> struct ImplTypeInfo<WebURL*>                         { typedef WKURLRef APIType; };
>  template<> struct ImplTypeInfo<WebURLRequest*>                  { typedef WKURLRequestRef APIType; };
It looks like you are missing the APITypeInfo definition here.

> WebKit2/UIProcess/API/C/WKSerializedScriptValue.cpp:43
> +JSValueRef WKSerializedScriptValueDeserialize(WKSerializedScriptValueRef scriptValueRef, JSContextRef contextRef, JSValueRef* exception)
> +{
> +    return toWK(serializedValueRef)->deserialize(contextRef, exceptionRef);
> +}
This won't compile.  You need to change serializedValueRef to scriptValueRef.

I believe you are also missing the WebKit2.pro and WebKit2.vcproj changes.

[Sam Weinig]

Comment on attachment 66802 [details]
Patch

Sorry, I meant r=me with those changes.

[Oliver Hunt]

Created attachment 66809 [details]
Patch

[WebKit Review Bot]

Attachment 66809 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/UIProcess/API/C/WKSerializedScriptValue.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/UIProcess/API/C/WKAPICast.h:79:  More than one command on the same line  [whitespace/newline] [4]
WebKit2/UIProcess/API/C/WKAPICast.h:105:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 3 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Oliver Hunt]

Created attachment 66814 [details]
Patch

[WebKit Review Bot]

Attachment 66814 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/UIProcess/API/C/WKSerializedScriptValue.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/UIProcess/API/C/WKAPICast.h:79:  More than one command on the same line  [whitespace/newline] [4]
WebKit2/UIProcess/API/C/WKAPICast.h:105:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 3 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Anders Carlsson]

Comment on attachment 66814 [details]
Patch

Please add WebSerializedScriptValue.h to WebKit2.vcproj, looks fine otherwise!

[Oliver Hunt]

Committed r66995: <http://trac.webkit.org/changeset/66995>