Bug 45334 - TextDocument should come in from the cold
Summary: TextDocument should come in from the cold
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-07 16:25 PDT by Adam Barth
Modified: 2010-09-08 01:52 PDT (History)
2 users (show)

See Also:

Attachments
Patch (26.50 KB, patch)
2010-09-07 16:28 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch (26.00 KB, patch)
2010-09-07 16:53 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch for landing (26.06 KB, patch)
2010-09-07 16:57 PDT, Adam Barth 		commit-queue: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-09-07 16:25:10 PDT 
TextDocument should come in from the cold
Comment 1 Adam Barth 2010-09-07 16:28:35 PDT 
Created attachment 66786 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-09-07 16:38:20 PDT 
Comment on attachment 66786 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=66786&action=prettypatch

> WebCore/html/parser/HTMLViewSourceParser.cpp:47
> +    m_tokenizer->setState(HTMLTokenizer::PLAINTEXTState);
We talked about just making HTMLViewTextSourceParser a subclass which does this in the constructor.

> WebCore/html/parser/TextDocumentParser.cpp:52
> +    attributes->insertAttribute(styleAttribute.release(), false);
What does false do?

> WebCore/html/parser/TextDocumentParser.cpp:78
> +    pumpTokenizer();
m_treeBuilder->finished() is needed.  Lame that every document parser needs to write all this stuff.
Comment 3 Adam Barth 2010-09-07 16:53:31 PDT 
Created attachment 66789 [details]
Patch
Comment 4 Eric Seidel (no email) 2010-09-07 16:56:41 PDT 
Comment on attachment 66789 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=66789&action=prettypatch

:)
Comment 5 Adam Barth 2010-09-07 16:57:41 PDT 
Created attachment 66791 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2010-09-07 19:30:41 PDT 
Comment on attachment 66791 [details]
Patch for landing

Rejecting patch 66791 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--wait-for-httpd', '--ignore-tests', 'compositing,media', '--quiet']" exit_code: 1
Running build-dumprendertree
Compiling Java tests
make: Nothing to be done for `default'.
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 20935 test cases.
http/tests/appcache/fallback.html -> failed

Exiting early after 1 failures. 19967 tests run.
635.60s total testing time

19966 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
27 test cases (<1%) had stderr output

Full output: http://queues.webkit.org/results/3939280
Comment 7 Adam Barth 2010-09-08 01:52:31 PDT 
Committed r66957: <http://trac.webkit.org/changeset/66957>