Bug 45334 – TextDocument should come in from the cold

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Adam Barth]

TextDocument should come in from the cold

[Adam Barth]

Created attachment 66786 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 66786 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=66786&action=prettypatch

> WebCore/html/parser/HTMLViewSourceParser.cpp:47
> +    m_tokenizer->setState(HTMLTokenizer::PLAINTEXTState);
We talked about just making HTMLViewTextSourceParser a subclass which does this in the constructor.

> WebCore/html/parser/TextDocumentParser.cpp:52
> +    attributes->insertAttribute(styleAttribute.release(), false);
What does false do?

> WebCore/html/parser/TextDocumentParser.cpp:78
> +    pumpTokenizer();
m_treeBuilder->finished() is needed.  Lame that every document parser needs to write all this stuff.

[Adam Barth]

Created attachment 66789 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 66789 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=66789&action=prettypatch

:)

[Adam Barth]

Created attachment 66791 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 66791 [details]
Patch for landing

Rejecting patch 66791 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--wait-for-httpd', '--ignore-tests', 'compositing,media', '--quiet']" exit_code: 1
Running build-dumprendertree
Compiling Java tests
make: Nothing to be done for `default'.
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 20935 test cases.
http/tests/appcache/fallback.html -> failed

Exiting early after 1 failures. 19967 tests run.
635.60s total testing time

19966 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
27 test cases (<1%) had stderr output

Full output: http://queues.webkit.org/results/3939280

[Adam Barth]

Committed r66957: <http://trac.webkit.org/changeset/66957>