Bug 45333 - Movies with track or movie matrices don't display in <video> elements (Safari 5/Windows)
Summary: Movies with track or movie matrices don't display in <video> elements (Safari...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2010-09-07 16:08 PDT by Jer Noble
Modified: 2010-09-10 23:26 PDT (History)
3 users (show)

See Also:

Attachments
Video-rotation (23.51 KB, patch)
2010-09-07 17:31 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Video-rotation (23.58 KB, patch)
2010-09-09 13:50 PDT, Jer Noble 		simon.fraser: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2010-09-07 16:08:35 PDT 
Movies shot with the iPhone 4 front camera don't display in Safari 5.
Comment 1 Jer Noble 2010-09-07 16:08:49 PDT 
<rdar://problem/8133126>
Comment 2 Jer Noble 2010-09-07 17:31:04 PDT 
Created attachment 66798 [details]
Video-rotation
Comment 3 WebKit Review Bot 2010-09-07 17:32:39 PDT 
Attachment 66798 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/ChangeLog:7:  Line contains tab character.  [whitespace/tab] [5]
WebCore/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
WebCore/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
WebCore/ChangeLog:10:  Line contains tab character.  [whitespace/tab] [5]
WebCore/ChangeLog:11:  Line contains tab character.  [whitespace/tab] [5]
WebCore/ChangeLog:17:  Line contains tab character.  [whitespace/tab] [5]
WebCore/ChangeLog:21:  Line contains tab character.  [whitespace/tab] [5]
WebCore/ChangeLog:23:  Line contains tab character.  [whitespace/tab] [5]
WebCore/ChangeLog:25:  Line contains tab character.  [whitespace/tab] [5]
WebCore/ChangeLog:27:  Line contains tab character.  [whitespace/tab] [5]
WebCore/platform/graphics/win/QTTrack.h:35:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 11 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Jer Noble 2010-09-09 13:50:57 PDT 
Created attachment 67090 [details]
Video-rotation

Fixed those blasted tabs.
Comment 5 WebKit Review Bot 2010-09-09 13:54:08 PDT 
Attachment 67090 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/platform/graphics/win/QTTrack.h:35:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Simon Fraser (smfr) 2010-09-09 14:13:30 PDT 
Comment on attachment 67090 [details]
Video-rotation

I think you should initialize m_movieTransform in the constructor. r=me.
Comment 7 Jer Noble 2010-09-10 23:26:56 PDT 
Committed r67285: <http://trac.webkit.org/changeset/67285>