Bug 45329 - [chromium] PlatformLayer's must get their owner reset when owner is destroyed
Summary: [chromium] PlatformLayer's must get their owner reset when owner is destroyed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Vangelis Kokkevis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-07 15:40 PDT by Vangelis Kokkevis
Modified: 2010-09-07 16:06 PDT (History)
0 users

See Also:

Attachments
Proposed patch (1.44 KB, patch)
2010-09-07 15:47 PDT, Vangelis Kokkevis 		fishd: review+
vangelis: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vangelis Kokkevis 2010-09-07 15:40:05 PDT 
A PlatformLayer's owner is a GraphicsLayer which holds a RefPtr to the PlatformLayer.  PlatformLayer's  can outlive their owning GraphicsLayer as other objects can also have references to them and therefore need to have their owner reset once that owner goes away.  Failing to do so can result in accessing memory that has been freed.
Comment 1 Vangelis Kokkevis 2010-09-07 15:47:11 PDT 
Created attachment 66779 [details]
Proposed patch
Comment 2 Vangelis Kokkevis 2010-09-07 16:06:09 PDT 
Committed r66923: <http://trac.webkit.org/changeset/66923>