Bug 45315 - Enable incremental results.json generation for non-layout tests.
Summary: Enable incremental results.json generation for non-layout tests.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-07 11:58 PDT by Kinuko Yasuda
Modified: 2010-09-07 22:54 PDT (History)
2 users (show)

See Also:

Attachments
Patch (6.74 KB, patch)
2010-09-07 12:26 PDT, Kinuko Yasuda 		ojan: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kinuko Yasuda 2010-09-07 11:58:38 PDT 
Enable incremental results.json generation for non-layout tests.

Also need to add a functionality to upload the results to the app-engine's test results server.
Comment 1 Kinuko Yasuda 2010-09-07 12:26:19 PDT 
Created attachment 66748 [details]
Patch
Comment 2 Victor Wang 2010-09-07 17:05:58 PDT 
Comment on attachment 66748 [details]
Patch

> +        json_files = ["incremental_results.json"]
replace "incremental_results.json" with INCREMENTAL_RESULTS_FILENAME
Comment 3 Ojan Vafai 2010-09-07 17:07:33 PDT 
Comment on attachment 66748 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=66748&action=prettypatch

Just a few nits.

> WebKitTools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:296
> +                print results_file_url
Did you mean to include this?

> WebKitTools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:532
> +                    self._builder_name, self._test_results_server)
Indentation is off. Have a couple extra spaces.

> WebKitTools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:595
> +        # Generate the JSON with incrementa flag enabled.
Typo: incrementa
Comment 4 Kinuko Yasuda 2010-09-07 22:54:56 PDT 
Committed r66953: <http://trac.webkit.org/changeset/66953>