Bug 45314 - Remove some unnecessary duplicate calls to string functions
Summary: Remove some unnecessary duplicate calls to string functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 45240
  Show dependency treegraph
 
Reported: 2010-09-07 11:44 PDT by Robert Hogan
Modified: 2010-09-08 13:58 PDT (History)
1 user (show)

See Also:


Attachments
Patch (3.38 KB, patch)
2010-09-07 11:48 PDT, Robert Hogan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Hogan 2010-09-07 11:44:37 PDT
Replace calls of the sort :

    StringImpl::create(buffer.toUtf8().constData(), buffer.toUtf8().length())

with


    QByteArray ba = buffer.toUtf8();
    return StringImpl::create(ba.constData(), ba.length());
Comment 1 Robert Hogan 2010-09-07 11:48:13 PDT
Created attachment 66747 [details]
Patch
Comment 2 Antonio Gomes 2010-09-07 11:51:37 PDT
Comment on attachment 66747 [details]
Patch

ba? :)
Comment 3 WebKit Commit Bot 2010-09-08 13:58:09 PDT
Comment on attachment 66747 [details]
Patch

Clearing flags on attachment: 66747

Committed r67012: <http://trac.webkit.org/changeset/67012>
Comment 4 WebKit Commit Bot 2010-09-08 13:58:15 PDT
All reviewed patches have been landed.  Closing bug.